Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v1.18: deprecate get_client and get_multi_client (backport of #177) #182

Merged
merged 2 commits into from
Mar 11, 2024
+4 −0
Merged

v1.18: deprecate get_client and get_multi_client (backport of #177) #182

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
15328bf
deprecate `get_client` and `get_multi_client` (#177)
gregcusack Mar 11, 2024
d8434f3
bump deprecated version numbers
gregcusack Mar 11, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions dos/src/main.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,6 +39,7 @@
//! ```
//!
#![allow(clippy::arithmetic_side_effects)]
#![allow(deprecated)]
use {
crossbeam_channel::{select, tick, unbounded, Receiver, Sender},
itertools::Itertools,
Expand Down
2 changes: 2 additions & 0 deletions gossip/src/gossip_service.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -193,6 +193,7 @@ pub fn discover(
}

/// Creates a ThinClient by selecting a valid node at random
#[deprecated(since = "1.18.0", note = "Interface will change")]
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh shoot, I didn't look carefully enough at this, sorry. Can you please fix this on master too?

Suggested change
#[deprecated(since = "1.18.0", note = "Interface will change")]
#[deprecated(since = "1.18.6", note = "Interface will change")]

pub fn get_client(
nodes: &[ContactInfo],
socket_addr_space: &SocketAddrSpace,
Expand All @@ -208,6 +209,7 @@ pub fn get_client(
ThinClient::new(rpc, tpu, connection_cache)
}

#[deprecated(since = "1.18.0", note = "Will be removed in favor of get_client")]
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
#[deprecated(since = "1.18.0", note = "Will be removed in favor of get_client")]
#[deprecated(since = "1.18.6", note = "Will be removed in favor of get_client")]

pub fn get_multi_client(
nodes: &[ContactInfo],
socket_addr_space: &SocketAddrSpace,
Expand Down
Loading