-
Notifications
You must be signed in to change notification settings - Fork 254
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature - Remove accounts executable flag checks #2182
Feature - Remove accounts executable flag checks #2182
Conversation
cef7572
to
7e815e1
Compare
7e815e1
to
f304b9e
Compare
71a4633
to
8a5257e
Compare
8a5257e
to
8631287
Compare
The Firedancer team maintains a line-for-line reimplementation of the |
5fbb7c5
to
e7cff7e
Compare
e7cff7e
to
0036428
Compare
0036428
to
8399add
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm.
We are one step closer to deprecate "executable".
Backports to the beta branch are to be avoided unless absolutely necessary for fixing bugs, security issues, and perf regressions. Changes intended for backport should be structured such that a minimum effective diff can be committed separately from any refactoring, plumbing, cleanup, etc that are not strictly necessary to achieve the goal. Any of the latter should go only into master and ride the normal stabilization schedule. Exceptions include CI/metrics changes, CLI improvements and documentation updates on a case by case basis. |
* Adds the feature. * Adds the feature gate logic. * Adjusts tests. * Adds deprecation attributes. * Set is_executable flag upon initialization in loader-v4. (cherry picked from commit 3bf9c2e)
* Adds the feature. * Adds the feature gate logic. * Adjusts tests. * Adds deprecation attributes. * Set is_executable flag upon initialization in loader-v4. (cherry picked from commit 3bf9c2e)
* Adds the feature. * Adds the feature gate logic. * Adjusts tests. * Adds deprecation attributes. * Set is_executable flag upon initialization in loader-v4. (cherry picked from commit 3bf9c2e)
See SIMD-0162