metrics: remove optimistic_slot_elapsed #2717
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
apfitzge
reviewed
Aug 23, 2024
| @@ -61,15 +61,6 @@ impl OptimisticConfirmationVerifier { | |||
| return; | |||
| } | |||
|
|
|||
| datapoint_info!( | |||
There was a problem hiding this comment.
I've never looked at this metric, but defering to @steviez's opinion since he's been more involved in replay than I have
There was a problem hiding this comment.
This one is kind of interesting, but I don't check it very often and I don't think we need every node reporting it. This information can be determined by other means (RPC, ledger-tool) as well.
That being said, the value is currently read in this dashboard:
Maybe we can remove it from the dashboard as part of this PR too ?
There was a problem hiding this comment.
I think we will have a new dashboard after the metric audit, but it's good to remove it from the file to avoid any misleading info! 0bef5e8
steviez
approved these changes
Sep 4, 2024
ray-kast
pushed a commit
to abklabs/agave
that referenced
this pull request
Nov 27, 2024
* metrics: remove optimistic_slot_elapsed * remove optimistic_slot_elapsed from grafana dashboard json
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of Changes
clean up unused metrics