v2.0: gossip: demote invalid duplicate proof errors to info (backport of #2754) #2759
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![mergify[bot]](https://avatars.githubusercontent.com/in/10562?s=60&v=4){kind=small}
* gossip: demote invalid duplicate proof errors to info * pr feedback: explicitly list every enum (cherry picked from commit 7b6e6c1)
behzadnouri
approved these changes
Aug 27, 2024
|
Only changes the log line. Demotes ERROR to INFO in case the error is non critical (a gossip user can intentionally trigger it). |
steviez
approved these changes
Aug 27, 2024
t-nelson
approved these changes
Aug 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Misconfigured or malicious nodes can send out duplicate proofs that are invalid.
This will result in a lot of ERROR log spam.
Summary of Changes
Separate out logging to use INFO for invalid duplicate proofs, and ERROR for errors in the processing pipeline.
This is an automatic backport of pull request #2754 done by [Mergify](https://mergify.com).