Uses IntMap in SlotOffsets #2891
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brooksprumo
dismissed stale reviews from jeffwashington and HaoranYi
via
c5ba602
brooksprumo
force-pushed
the
no-hash/slot-offsets
branch
from
b35aaf9 to
c5ba602
Compare
|
I force-pushed to fix a merge conflict. No code changes since the last review. Sorry about the re-review, and thanks for understanding. |
HaoranYi
approved these changes
Sep 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
SlotOffsets is a map of slot to offsets. It does not need cryptographic security, so it can use IntMap instead of HashMap for better performance.
Summary of Changes
Replace HashMap with IntMap