Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

extract reward-info crate #2971

Merged
merged 6 commits into from
Nov 5, 2024
Merged

Conversation

kevinheavey
Copy link

Problem

solana_sdk::reward_type and solana_sdk::reward_info impose a solana-sdk dependency on solana-rpc-client-api

Summary of Changes

  • Move them into a single solana-reward-info crate.
  • Re-export in their old modules and add deprecation notices
  • Make serde optional in the new crate

@kevinheavey kevinheavey force-pushed the reward-info-crate branch 2 times, most recently from eb8a31a to 830c028 Compare September 25, 2024 10:26
@kevinheavey kevinheavey force-pushed the reward-info-crate branch 4 times, most recently from 6c3993f to 50e756d Compare October 13, 2024 11:48
@kevinheavey kevinheavey force-pushed the reward-info-crate branch 2 times, most recently from cf74a91 to 55a2234 Compare October 15, 2024 13:14
Copy link

@buffalojoec buffalojoec left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe I'm missing something, but where are these types used in solana-rpc-client-api?

As a side note, it looks like everything solana-rpc-client-api depends on from the SDK has been broken up into smaller crates, except for these two:

  • SignerError
  • transaction::Result

Seems like we're pretty close to being able to just swap in the smaller crates for all of solana-rpc-client-api.

@kevinheavey
Copy link
Author

Maybe I'm missing something, but where are these types used in solana-rpc-client-api?

The dependency is indirect, via solana-transaction-status-client-types

Seems like we're pretty close to being able to just swap in the smaller crates for all of solana-rpc-client-api.

Yeah this is being tracked in #3027

Copy link

@buffalojoec buffalojoec left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works for me. Just 2 nits.

sdk/src/lib.rs Outdated Show resolved Hide resolved
sdk/src/reward_info.rs Outdated Show resolved Hide resolved
sdk/src/lib.rs Outdated Show resolved Hide resolved
@yihau yihau added the automerge automerge Merge this Pull Request automatically once CI passes label Nov 5, 2024
@mergify mergify bot merged commit c3bc1bf into anza-xyz:master Nov 5, 2024
53 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automerge automerge Merge this Pull Request automatically once CI passes need:merge-assist
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants