-
Notifications
You must be signed in to change notification settings - Fork 254
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
extract reward-info crate #2971
Conversation
eb8a31a
to
830c028
Compare
6c3993f
to
50e756d
Compare
cf74a91
to
55a2234
Compare
a8f3da6
to
2924c7e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe I'm missing something, but where are these types used in solana-rpc-client-api
?
As a side note, it looks like everything solana-rpc-client-api
depends on from the SDK has been broken up into smaller crates, except for these two:
SignerError
transaction::Result
Seems like we're pretty close to being able to just swap in the smaller crates for all of solana-rpc-client-api
.
The dependency is indirect, via solana-transaction-status-client-types
Yeah this is being tracked in #3027 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works for me. Just 2 nits.
Problem
solana_sdk::reward_type
andsolana_sdk::reward_info
impose asolana-sdk
dependency onsolana-rpc-client-api
Summary of Changes
solana-reward-info
crate.