v2.0: ignore tonic audit report #3051
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
block on #3048 |
|
Agreed. We don't have any risk on this one |
willhickey
previously approved these changes
Oct 2, 2024
bw-solana
reviewed
Oct 2, 2024
| @@ -33,6 +33,9 @@ cargo_audit_ignores=( | |||
|
|
|||
| # curve25519-dalek | |||
| --ignore RUSTSEC-2024-0344 | |||
|
|
|||
| # tonic | |||
There was a problem hiding this comment.
Might be nice to add more to the comment. Something like:
"When using tonic::transport::Server there is a remote DoS attack that can cause the server to exit cleanly on accepting a tcp/tls stream.
Ignoring because we do not use this functionality."
There was a problem hiding this comment.
more specifically, we don't use the server side of tonic at all
willhickey
approved these changes
Oct 2, 2024
bw-solana
approved these changes
Oct 2, 2024
|
updated: TIL it won't dismiss your approves |
|
all green! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
related to #3050
If I’m not missing anything, we don’t use the fn, so it should be okay to ignore it in the channel branch
Summary of Changes
ignore it