Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v2.0: ignore tonic audit report #3051

Merged
merged 2 commits into from
Oct 2, 2024
Merged

v2.0: ignore tonic audit report #3051

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
55598e7
fix audit
yihau Oct 2, 2024
349f83f
add more comment
yihau Oct 2, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions ci/do-audit.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,6 +33,12 @@ cargo_audit_ignores=(

# curve25519-dalek
--ignore RUSTSEC-2024-0344

# tonic
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Might be nice to add more to the comment. Something like:
"When using tonic::transport::Server there is a remote DoS attack that can cause the server to exit cleanly on accepting a tcp/tls stream.

Ignoring because we do not use this functionality."

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

more specifically, we don't use the server side of tonic at all

# When using tonic::transport::Server there is a remote DoS attack that can cause
# the server to exit cleanly on accepting a tcp/tls stream.
# Ignoring because we do not use this functionality.
--ignore RUSTSEC-2024-0376
)
scripts/cargo-for-all-lock-files.sh audit "${cargo_audit_ignores[@]}" | $dep_tree_filter
# we want the `cargo audit` exit code, not `$dep_tree_filter`'s
Expand Down