Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Extract quic-definitions crate #3119

Merged
merged 4 commits into from
Nov 12, 2024
Merged

Extract quic-definitions crate #3119

merged 4 commits into from
Nov 12, 2024

Conversation

kevinheavey
Copy link

Problem

solana_sdk::quic imposes a solana_sdk dep on solana_quic_client and solana_streamer

Summary of Changes

  • Move to its own crate and re-export with deprecation

This branches off #3087 so that needs to be merged first

@kevinheavey kevinheavey mentioned this pull request Oct 9, 2024
Closed
@kevinheavey kevinheavey force-pushed the extract-quic-definitions branch 2 times, most recently from bd2b0e0 to 3c83cad Compare October 16, 2024 10:53
@kevinheavey kevinheavey force-pushed the extract-quic-definitions branch 3 times, most recently from fdf0223 to 2f13420 Compare October 29, 2024 22:17
@kevinheavey kevinheavey mentioned this pull request Nov 2, 2024
Merged
@kevinheavey kevinheavey force-pushed the extract-quic-definitions branch from 2f13420 to 8a9aacb Compare November 2, 2024 15:58
@kevinheavey kevinheavey mentioned this pull request Nov 2, 2024
Merged
@kevinheavey kevinheavey force-pushed the extract-quic-definitions branch 2 times, most recently from c1ac7d3 to 278fb65 Compare November 6, 2024 17:28
@kevinheavey kevinheavey marked this pull request as ready for review November 6, 2024 17:34
@kevinheavey kevinheavey force-pushed the extract-quic-definitions branch from 278fb65 to 7020cb8 Compare November 7, 2024 11:58
@kevinheavey kevinheavey requested a review from joncinque November 9, 2024 06:18
joncinque
joncinque reviewed Nov 12, 2024
View reviewed changes
Copy link

@joncinque joncinque left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a few nits, then we can get this in! @yihau can you accept ownership of solana-quic-definitions

sdk/quic-definitions/src/lib.rs Outdated Show resolved Hide resolved
sdk/quic-definitions/src/lib.rs Outdated Show resolved Hide resolved
sdk/quic-definitions/src/lib.rs Outdated Show resolved Hide resolved
@yihau
Copy link
Member

yihau commented Nov 12, 2024

✅

@kevinheavey kevinheavey added the automerge automerge Merge this Pull Request automatically once CI passes label Nov 12, 2024
joncinque
joncinque approved these changes Nov 12, 2024
View reviewed changes
Copy link

@joncinque joncinque left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thanks!

@joncinque joncinque merged commit 2c819d0 into anza-xyz:master Nov 12, 2024
53 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joncinque joncinque joncinque approved these changes

Assignees
No one assigned
Labels
automerge automerge Merge this Pull Request automatically once CI passes need:merge-assist
Projects
SDK Breakup + Breakout
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kevinheavey @yihau @joncinque