Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds --accounts-db-hash-threads to validator and ledger-tool #3233

Merged
merged 1 commit into from
Oct 24, 2024

Conversation

brooksprumo
Copy link

@brooksprumo brooksprumo commented Oct 20, 2024

Problem

There's not a way to specify the number of threads to use for the thread pool that does the accounts hash calculations. Also, see #105

Summary of Changes

Add a hidden cli arg.

@brooksprumo brooksprumo self-assigned this Oct 20, 2024
@brooksprumo brooksprumo force-pushed the cli/num-hash-threads branch 2 times, most recently from 27b3b10 to a255cb9 Compare October 20, 2024 19:59
@brooksprumo brooksprumo marked this pull request as ready for review October 20, 2024 21:30
jeffwashington
jeffwashington previously approved these changes Oct 21, 2024
Copy link

@jeffwashington jeffwashington left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

HaoranYi
HaoranYi previously approved these changes Oct 21, 2024
Copy link

@HaoranYi HaoranYi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems a good tunable cli to have.
Lgtm.

Copy link

@steviez steviez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have my PR up (#3281) to show how I avoid the double thread pool creation; let's chat + coordinate in the morning

accounts-db/src/accounts_db.rs Outdated Show resolved Hide resolved
ledger-tool/src/args.rs Show resolved Hide resolved
validator/src/cli.rs Outdated Show resolved Hide resolved
@brooksprumo brooksprumo dismissed stale reviews from HaoranYi and jeffwashington via 65f8b35 October 24, 2024 17:46
Copy link

@steviez steviez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

validator/src/cli/thread_args.rs Show resolved Hide resolved
@brooksprumo brooksprumo added the automerge automerge Merge this Pull Request automatically once CI passes label Oct 24, 2024
@mergify mergify bot merged commit 2065973 into anza-xyz:master Oct 24, 2024
41 checks passed
@brooksprumo brooksprumo deleted the cli/num-hash-threads branch October 24, 2024 19:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automerge automerge Merge this Pull Request automatically once CI passes
Projects
Development

Successfully merging this pull request may close these issues.

4 participants