Add CLI args for AccountsDb thread pools to validator #3281
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
steviez
commented
Oct 23, 2024
steviez
force-pushed
the
val_acc_db_thread_args
branch
2 times, most recently
from
4f2e788 to
4596af9
Compare
steviez
changed the title
steviez
changed the title
steviez
changed the title
steviez
force-pushed
the
val_acc_db_thread_args
branch
from
4596af9 to
2d3bfde
Compare
steviez
force-pushed
the
val_acc_db_thread_args
branch
from
2d3bfde to
a71bda3
Compare
steviez
force-pushed
the
val_acc_db_thread_args
branch
from
a71bda3 to
bc2655f
Compare
brooksprumo
reviewed
Oct 24, 2024
steviez
commented
Oct 24, 2024
There was a problem hiding this comment.
Just did a series of rebases to clean up the commit history; happy with how minimal these commits are after the handful of cleanup PR's that came before them
I think the logic is straight forward, but I would appreciate thoughts on the "process" pool naming. This is the one that I think I've heard y'all call "foreground" before. I wasn't sure if we wanted to bubble foreground all the way up tho.
I intentionally used "foreground" on the more hidden function, and "process" for AccountsDbConfig and the CLI; not sure which way we'll go but I anticipate having to incorporate y'alls feedback and adjusting so I left the mix in
ray-kast
pushed a commit
to abklabs/agave
that referenced
this pull request
Nov 27, 2024
Add hidden args to control AccountsDb foreground pool, AccountsDb clean pool, and AccountsIndex flush pool
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Done:
This PR is on top of #3270 and should ship after it.Done:
Rebase on top of #3233 after it shipsProblem
See #105 - we want a way to control the size of all thread pools
Summary of Changes