Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extract secp256k1-program #3331

Merged
merged 9 commits into from
Nov 20, 2024

Conversation

kevinheavey
Copy link

Problem
solana_sdk::secp256k1_instruction blocks ripping out solana_sdk::precompiles

Summary of Changes

  • Move to its own crate and re-export with deprecation notice
  • Make serde and bincode optional in the new crate

@kevinheavey kevinheavey changed the title Extract secp256k1 instruction Extract secp256k1-instruction Oct 28, 2024
@kevinheavey kevinheavey force-pushed the extract-secp256k1-instruction branch from 0cb21e2 to 4427b44 Compare October 29, 2024 09:33
@kevinheavey kevinheavey force-pushed the extract-secp256k1-instruction branch 3 times, most recently from b73aef4 to afb137b Compare November 12, 2024 10:09
@kevinheavey kevinheavey force-pushed the extract-secp256k1-instruction branch from afb137b to c24520c Compare November 14, 2024 07:53
@kevinheavey kevinheavey requested a review from febo November 14, 2024 11:19
@kevinheavey kevinheavey force-pushed the extract-secp256k1-instruction branch from c24520c to 0b19841 Compare November 14, 2024 12:05
@kevinheavey kevinheavey changed the title Extract secp256k1-instruction Extract secp256k1-program Nov 14, 2024
@kevinheavey kevinheavey force-pushed the extract-secp256k1-instruction branch 5 times, most recently from 864a74a to edec69c Compare November 16, 2024 07:31
Copy link

@febo febo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good – just a couple of questions.

@febo
Copy link

febo commented Nov 20, 2024

I can't comment exactly there, but what do you think if we update the examples on the docs to use the individual crates instead of the solana-program/-sdk? Happy to push the change to your branch if that is easier.

@kevinheavey kevinheavey force-pushed the extract-secp256k1-instruction branch from 08b2ad6 to 94d0082 Compare November 20, 2024 19:28
@kevinheavey kevinheavey force-pushed the extract-secp256k1-instruction branch from 94d0082 to 9ffe35d Compare November 20, 2024 21:22
@febo febo merged commit 92068d1 into anza-xyz:master Nov 20, 2024
53 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants