forked from solana-labs/solana
-
Notifications
You must be signed in to change notification settings - Fork 254
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Extract secp256k1-program #3331
Merged
febo
merged 9 commits into
anza-xyz:master
from
kevinheavey:extract-secp256k1-instruction
Nov 20, 2024
Merged
Extract secp256k1-program #3331
febo
merged 9 commits into
anza-xyz:master
from
kevinheavey:extract-secp256k1-instruction
Nov 20, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kevinheavey
changed the title
Extract secp256k1 instruction
Extract secp256k1-instruction
Oct 28, 2024
kevinheavey
force-pushed
the
extract-secp256k1-instruction
branch
from
October 29, 2024 09:33
0cb21e2
to
4427b44
Compare
kevinheavey
force-pushed
the
extract-secp256k1-instruction
branch
3 times, most recently
from
November 12, 2024 10:09
b73aef4
to
afb137b
Compare
kevinheavey
force-pushed
the
extract-secp256k1-instruction
branch
from
November 14, 2024 07:53
afb137b
to
c24520c
Compare
kevinheavey
force-pushed
the
extract-secp256k1-instruction
branch
from
November 14, 2024 12:05
c24520c
to
0b19841
Compare
kevinheavey
force-pushed
the
extract-secp256k1-instruction
branch
5 times, most recently
from
November 16, 2024 07:31
864a74a
to
edec69c
Compare
febo
reviewed
Nov 20, 2024
febo
reviewed
Nov 20, 2024
febo
reviewed
Nov 20, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good – just a couple of questions.
I can't comment exactly there, but what do you think if we update the examples on the docs to use the individual crates instead of the |
kevinheavey
force-pushed
the
extract-secp256k1-instruction
branch
from
November 20, 2024 19:28
08b2ad6
to
94d0082
Compare
kevinheavey
force-pushed
the
extract-secp256k1-instruction
branch
from
November 20, 2024 21:22
94d0082
to
9ffe35d
Compare
febo
approved these changes
Nov 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
solana_sdk::secp256k1_instruction blocks ripping out solana_sdk::precompiles
Summary of Changes