Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extract precompiles crate #3622

Merged
merged 3 commits into from
Nov 21, 2024
Merged

Conversation

kevinheavey
Copy link

@kevinheavey kevinheavey commented Nov 14, 2024

Problem

solana_sdk::precompiles blocks pulling out solana_sdk::transaction

Summary of Changes

  • Move to its own crate and and re-export contents with deprecation

This branches off #3331 so that needs to be merged first (update: done)

@kevinheavey kevinheavey force-pushed the extract-precompiles branch 9 times, most recently from d32b76b to 573299c Compare November 21, 2024 00:14
@kevinheavey kevinheavey marked this pull request as ready for review November 21, 2024 00:19
@kevinheavey kevinheavey requested a review from febo November 21, 2024 00:24
joncinque
joncinque previously approved these changes Nov 21, 2024
Copy link

@joncinque joncinque left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one little bit for the docs, then this is good to go -- @yihau can you accept ownership of solana-precompiles?

side note: sorry, I only noticed you already requested a review from febo right as I was submitting this. Didn't mean to rug!

sdk/precompiles/src/lib.rs Show resolved Hide resolved
sdk/precompiles/src/lib.rs Show resolved Hide resolved
@joncinque joncinque added the automerge automerge Merge this Pull Request automatically once CI passes label Nov 21, 2024
Copy link

mergify bot commented Nov 21, 2024

automerge label removed due to a CI failure

@mergify mergify bot removed the automerge automerge Merge this Pull Request automatically once CI passes label Nov 21, 2024
@joncinque joncinque added the automerge automerge Merge this Pull Request automatically once CI passes label Nov 21, 2024
@mergify mergify bot merged commit 1b8a4ad into anza-xyz:master Nov 21, 2024
54 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automerge automerge Merge this Pull Request automatically once CI passes need:merge-assist
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants