Extract client code in send_transaction_service into a new structure #3423

KirillLykov · 2024-11-01T10:58:44Z

Problem

In order to be able to use new client code in the SendTransactionService (see #3444), I need to wrap network-related code with the new structure ConnectionCacheClient.

Summary of Changes

To extract network code into a new structure, I had to move some auxiliary code into separate files.
Beside of that, changes are pretty minimal and I deliberately haven't tried to optimize existing code to keep changes minimal. It just does almost exactly the same as the old one.

mergify · 2024-11-01T10:59:17Z

If this PR represents a change to the public RPC API:

Make sure it includes a complementary update to rpc-client/ (example)
Open a follow-up PR to update the JavaScript client @solana/web3.js (example)

Thank you for keeping the RPC clients in sync with the server API @KirillLykov.

send-transaction-service/src/send_transaction_service.rs

KirillLykov · 2024-11-01T11:18:20Z

If this PR represents a change to the public RPC API:
1. Make sure it includes a complementary update to `rpc-client/` ([example](https://github.com/solana-labs/solana/pull/29558/files))

2. Open a follow-up PR to update the JavaScript client `@solana/web3.js` ([example](https://github.com/solana-labs/solana-web3.js/pull/2868/files))
Thank you for keeping the RPC clients in sync with the server API @KirillLykov.

Sounds wrong, I haven't changed any rpc calls. For rpc the only thing that has changed is probably passing connection_cache by value instead of reference.

send-transaction-service/src/transaction_client.rs

Also introduce TransactionClient, but don't use it in this commit.

send-transaction-service/src/send_transaction_service_stats.rs

send-transaction-service/src/transaction_client.rs

mergify · 2024-11-04T14:02:23Z

Backports to the beta branch are to be avoided unless absolutely necessary for fixing bugs, security issues, and perf regressions. Changes intended for backport should be structured such that a minimum effective diff can be committed separately from any refactoring, plumbing, cleanup, etc that are not strictly necessary to achieve the goal. Any of the latter should go only into master and ride the normal stabilization schedule. Exceptions include CI/metrics changes, CLI improvements and documentation updates on a case by case basis.

KirillLykov · 2024-11-04T14:57:17Z

@joncinque Do you think that this warning makes sense for these changes: #3423 (comment) ? This PR looks pretty innocent to me but would like to double check

joncinque · 2024-11-04T18:10:13Z

@joncinque Do you think that this warning makes sense for these changes: #3423 (comment) ? This PR looks pretty innocent to me but would like to double check

This is perfectly safe -- that rule is being triggered due to the change in rpc.rs, but the change here is not impacting the public API. Go for it!

…3423) In order to be able to use new client code in the `SendTransactionService`, I need to wrap network-related code with the new structure ConnectionCacheClient. To to that I also had to move some auxiliary code into separate files. (cherry picked from commit 144925e)

KirillLykov changed the title ~~Klykov/extract client code~~ Extract client code in send_transaction_service into a new structure Nov 1, 2024