Add tpu-client-next to SendTransactionService
#3444
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also introduce TransactionClient, but don't use it in this commit.
It still uses ConnectionCacheClient everywhere
|
If this PR represents a change to the public RPC API:
Thank you for keeping the RPC clients in sync with the server API @KirillLykov. |
KirillLykov
commented
Nov 2, 2024
| @@ -68,7 +68,7 @@ impl AsyncTaskSemaphore { | |||
| lazy_static! { | |||
| static ref ASYNC_TASK_SEMAPHORE: AsyncTaskSemaphore = | |||
| AsyncTaskSemaphore::new(MAX_OUTSTANDING_TASK); | |||
| static ref RUNTIME: Runtime = tokio::runtime::Builder::new_multi_thread() | |||
| pub static ref RUNTIME: Runtime = tokio::runtime::Builder::new_multi_thread() | |||
There was a problem hiding this comment.
The idea is to use the same runtime in ConnectionCache as in the tpu-client-next. Since blocking ConnectionCache uses this RUNTIME static, the less invasive was to make it pub and use where needed.
This was referenced Nov 4, 2024
KirillLykov
commented
Nov 5, 2024
| @@ -1508,7 +1568,11 @@ impl Validator { | |||
| ); | |||
|
|
|||
| *start_progress.write().unwrap() = ValidatorStartProgress::Running; | |||
| key_notifies.push(connection_cache); | |||
| if config.use_tpu_client_next { | |||
| unimplemented!(); | |||
There was a problem hiding this comment.
This is something I need to implement still
KirillLykov
commented
Nov 5, 2024
| .tpu(Protocol::QUIC) | ||
| .map_err(|err| ValidatorError::Other(format!("{err}")))?; | ||
| let client = spawn_tpu_client_send_txs( | ||
| &*RUNTIME, // use the same runtime as ConnectionCache |
|
closed in favor of #3515 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
This PR is based on #3423
It adds a new client type to the SendTransactionService and instruments tests to use both.
Summary of Changes