Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure that Rc in AccountInfo is not stored in an account #3471

Merged
merged 2 commits into from
Nov 20, 2024

Conversation

seanyoung
Copy link

Problem

With direct mapping, AccountInfo should not be allowed to be stored in accounts; that includes the Rc<T> as well.

Summary of Changes

Fixes #

Copy link

mergify bot commented Nov 4, 2024

The Firedancer team maintains a line-for-line reimplementation of the
native programs, and until native programs are moved to BPF, those
implementations must exactly match their Agave counterparts.
If this PR represents a change to a native program implementation (not
tests), please include a reviewer from the Firedancer team. And please
keep refactors to a minimum.

@seanyoung seanyoung marked this pull request as ready for review November 5, 2024 13:32
Lichtso
Lichtso previously approved these changes Nov 5, 2024
@seanyoung seanyoung merged commit 030a558 into anza-xyz:master Nov 20, 2024
50 checks passed
@seanyoung seanyoung deleted the rc-address branch November 20, 2024 16:19
@seanyoung seanyoung added the v2.1 Backport to v2.1 branch label Nov 20, 2024
Copy link

mergify bot commented Nov 20, 2024

Backports to the beta branch are to be avoided unless absolutely necessary for fixing bugs, security issues, and perf regressions. Changes intended for backport should be structured such that a minimum effective diff can be committed separately from any refactoring, plumbing, cleanup, etc that are not strictly necessary to achieve the goal. Any of the latter should go only into master and ride the normal stabilization schedule. Exceptions include CI/metrics changes, CLI improvements and documentation updates on a case by case basis.

mergify bot pushed a commit that referenced this pull request Nov 20, 2024
* Ensure that Rc in AccountInfo is not stored in an account

(cherry picked from commit 030a558)
seanyoung added a commit that referenced this pull request Dec 4, 2024
…port of #3471) (#3723)

Ensure that Rc in AccountInfo is not stored in an account (#3471)

* Ensure that Rc in AccountInfo is not stored in an account

(cherry picked from commit 030a558)

Co-authored-by: Sean Young <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
v2.1 Backport to v2.1 branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants