Extract solana-transaction from solana-sdk #3634

kevinheavey · 2024-11-14T15:35:38Z

Problem

solana_sdk::transaction needs to be pulled out of solana_sdk

Summary of Changes

Move to its own crate and re-export for backwards compatibility as required, with deprecation notices
Move solana_sdk::simple_vote_transaction_checker to this crate (not much choice here as there'd be a circular dep otherwise)
Move solana_sdk::transaction::Result to solana_transaction_error::TransactionResult and re-export in solana_sdk::transaction with deprecation. This should have been done before but it was quite noticeable when moving things that it clearly belongs in solana_transaction_error
Put the verify_precompiles methods behind a feature gate "precompiles", as these bring in extra dependencies
Put the other verify and verify_* methods behind a feature gate "verify", as they bring in extra dependencies (not as many as the precompiles though)
Make serde and bincode optional in the new crate. ~~The new crate still depends indirectly on serde and bincode for now because it depends on solana-program~~
Make blake3 optional in the new crate

This branches off #3622 so that needs to be merged first (update: done)

mergify · 2024-11-27T21:46:24Z

If this PR represents a change to the public RPC API:

Make sure it includes a complementary update to rpc-client/ (example)
Open a follow-up PR to update the JavaScript client @solana/web3.js (example)

Thank you for keeping the RPC clients in sync with the server API @kevinheavey.

joncinque

Thanks for taking this one on too. The separation of precompiles and verify makes sense, we should just use solana_system_interface and solana_message instead of solana_program

joncinque · 2024-12-03T12:42:05Z

sdk/instruction/Cargo.toml

@@ -48,7 +48,7 @@ serde = [
 std = []

 [package.metadata.docs.rs]
-targets = ["x86_64-unknown-linux-gnu"]
+targets = ["x86_64-unknown-linux-gnu", "wasm32-unknown-unknown"]


What's this change for?

Can't remember why it happened in this PR but it is a good change, otherwise you can't see the wasm-specific code on docs.rs

it's possible i meant to add it for the solana-transaction crate. But it matters for solana-instruction too

If it's not needed, let's make the change in a separate PR. That way we can add it to all of the affected crates at once. I put in #3901 for it

sdk/transaction/src/sanitized.rs

joncinque · 2024-12-03T12:57:39Z

sdk/src/transaction.rs

@@ -0,0 +1,21 @@
+#![cfg(feature = "full")]
+#[deprecated(since = "2.2.0", note = "Use solana_transaction_error crate instead")]


nit: all of these re-exports except for TransactionResult were already deprecated as of 2.1.0, but it's fine to bump this up for simplicity

sdk/transaction/src/sanitized.rs

sdk/transaction/src/lib.rs

sdk/transaction/src/sanitized.rs

sdk/transaction/src/versioned/mod.rs

sdk/transaction/src/wasm.rs

kevinheavey · 2024-12-03T16:11:08Z

@apfitzge I see that you are the owner of the empty solana-transaction crate: https://crates.io/crates/solana-transaction/settings

Could you please add anza-team as an owner so @yihau can take it over?

apfitzge · 2024-12-03T16:40:43Z

@apfitzge I see that you are the owner of the empty solana-transaction crate: https://crates.io/crates/solana-transaction/settings

Could you please add anza-team as an owner so @yihau can take it over?

Yeah, I'll transfer ownership when I get to my desk

apfitzge · 2024-12-03T17:49:41Z

@yihau I added anza-team as an owner on crates.io

#### Problem As pointed out in [this PR comment](anza-xyz#3634 (comment)) it's good to specify that docs build for wasm32 where needed. Also, solana-sdk and solana-program don't configure docs builds with all features enabled. #### Summary of changes In most places, add "wasm32-unknown-unknown" as a build target. For sdk and program, also configure the features to be enabled.

joncinque

Really close, just one last little nit and the bit about solana-instruction's Cargo.toml

sdk/transaction/src/lib.rs

joncinque

Looks great, thanks!

#### Problem As pointed out in [this PR comment](#3634 (comment)) it's good to specify that docs build for wasm32 where needed. Also, solana-sdk and solana-program don't configure docs builds with all features enabled. #### Summary of changes In most places, add "wasm32-unknown-unknown" as a build target. For sdk and program, also configure the features to be enabled.

mergify bot added the need:merge-assist label Nov 14, 2024

kevinheavey force-pushed the extract-transaction branch 5 times, most recently from 3186d52 to 303be04 Compare November 14, 2024 17:00

kevinheavey mentioned this pull request Nov 14, 2024

Liberate the solana-client family from solana-sdk #3027

Closed

kevinheavey force-pushed the extract-transaction branch 5 times, most recently from 0dcdc95 to 936e4af Compare November 21, 2024 00:15

kevinheavey force-pushed the extract-transaction branch from 936e4af to b778d4e Compare November 25, 2024 17:27

kevinheavey marked this pull request as ready for review November 25, 2024 17:56

kevinheavey force-pushed the extract-transaction branch 2 times, most recently from 86eeea0 to dcd740a Compare November 26, 2024 07:28

kevinheavey requested a review from joncinque November 26, 2024 08:51

This was referenced Nov 28, 2024

Extract client-traits crate #3829

Merged

remove solana-sdk from transaction-status-client-types #3831

Merged

remove solana-sdk from rpc-client #3833

Merged

Extract system-transaction crate #3834

Merged

kevinheavey force-pushed the extract-transaction branch from c750530 to 275a26f Compare November 29, 2024 10:50

kevinheavey mentioned this pull request Dec 2, 2024

remove solana-sdk from svm-transaction #3854

Merged

kevinheavey force-pushed the extract-transaction branch 2 times, most recently from 3b6ec80 to f347973 Compare December 2, 2024 22:04

kevinheavey mentioned this pull request Dec 2, 2024

move program::wasm::instructions to instruction crate #3874

Merged

kevinheavey added 3 commits December 3, 2024 17:23

extract transaction crate

db3972b

make serde and bincode optional

b25ea7d

fix frozen-abi support

4cf2f68

kevinheavey added 11 commits December 3, 2024 17:23

missing feature activation

50bee51

add doc_auto_cfg

16e42e9

add "wasm32-unknown-unknown" to doc targets

5efd4ba

make solana-feature-set optional

3a299bf

inline some consts

3186832

fix wasm support

37058f0

update expected error

6c29379

update expected error

20b61ec

missing #![cfg(feature = "full")]

1a36b04

update digest

97f389f

update digest

e22445e

joncinque reviewed Dec 3, 2024

View reviewed changes

kevinheavey added 3 commits December 3, 2024 18:07

remove solana-program (except for dev deps)

8b0db58

add wasm32-unknown-unknown to doc targets

11a6137

update docs links

183dcf3

kevinheavey force-pushed the extract-transaction branch from a65746c to 183dcf3 Compare December 3, 2024 14:14

tighten deps

3ed1367

joncinque mentioned this pull request Dec 4, 2024

sdk: Add wasm target for docs #3901

Merged

joncinque reviewed Dec 4, 2024

View reviewed changes

sdk/transaction/src/lib.rs Outdated Show resolved Hide resolved

kevinheavey added 2 commits December 4, 2024 04:18

remove extraneous commit

f3faa9d

use explicit link

26901da

joncinque approved these changes Dec 4, 2024

View reviewed changes

joncinque added the automerge automerge Merge this Pull Request automatically once CI passes label Dec 4, 2024

mergify bot merged commit e4e232c into anza-xyz:master Dec 4, 2024
52 of 53 checks passed

joncinque mentioned this pull request Dec 4, 2024

CI: Add "check" step as an automerge requirement #3910

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Extract solana-transaction from solana-sdk #3634

Extract solana-transaction from solana-sdk #3634

kevinheavey commented Nov 14, 2024 •

edited

Loading

mergify bot commented Nov 27, 2024

joncinque left a comment

joncinque Dec 3, 2024

kevinheavey Dec 3, 2024

kevinheavey Dec 3, 2024

joncinque Dec 4, 2024

joncinque Dec 3, 2024

kevinheavey commented Dec 3, 2024

apfitzge commented Dec 3, 2024

apfitzge commented Dec 3, 2024

joncinque left a comment

joncinque left a comment

		@@ -0,0 +1,21 @@
		#![cfg(feature = "full")]
		#[deprecated(since = "2.2.0", note = "Use solana_transaction_error crate instead")]

Extract solana-transaction from solana-sdk #3634

Extract solana-transaction from solana-sdk #3634

Conversation

kevinheavey commented Nov 14, 2024 • edited Loading

Problem

Summary of Changes

mergify bot commented Nov 27, 2024

joncinque left a comment

Choose a reason for hiding this comment

joncinque Dec 3, 2024

Choose a reason for hiding this comment

kevinheavey Dec 3, 2024

Choose a reason for hiding this comment

kevinheavey Dec 3, 2024

Choose a reason for hiding this comment

joncinque Dec 4, 2024

Choose a reason for hiding this comment

joncinque Dec 3, 2024

Choose a reason for hiding this comment

kevinheavey commented Dec 3, 2024

apfitzge commented Dec 3, 2024

apfitzge commented Dec 3, 2024

joncinque left a comment

Choose a reason for hiding this comment

joncinque left a comment

Choose a reason for hiding this comment

kevinheavey commented Nov 14, 2024 •

edited

Loading