-
Notifications
You must be signed in to change notification settings - Fork 254
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
windows: Use vcpkg for openssl dep #73
Conversation
7f1e86a
to
7b33297
Compare
Backports to the beta branch are to be avoided unless absolutely necessary for fixing bugs, security issues, and perf regressions. Changes intended for backport should be structured such that a minimum effective diff can be committed separately from any refactoring, plumbing, cleanup, etc that are not strictly necessary to achieve the goal. Any of the latter should go only into master and ride the normal stabilization schedule. Exceptions include CI/metrics changes, CLI improvements and documentation updates on a case by case basis. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🪖
(cherry picked from commit b78c070)
windows: Use vcpkg for openssl dep (#73) (cherry picked from commit b78c070) Co-authored-by: Jon C <[email protected]>
…nza-xyz#86) windows: Use vcpkg for openssl dep (anza-xyz#73) (cherry picked from commit b78c070) Co-authored-by: Jon C <[email protected]>
Problem
The windows build of
solana-test-validator.exe
does not currently work on a fresh windows machine. Users get two errors:And also for
libcrypto-3-x64.dll
. This is happening because these libraries are linked dynamically into the executable, but machines don't have them unless they are installed withchoco
, just like during the CI build.Summary of Changes
Rather than picking up the dynamic libs with
choco
, usevcpkg
to fetch the static versions of the libraries, and link them directly into the executable.I triggered the run on my own branch, and you'll see when running
ldd solana-test-validator
(at the end of the run) that libcrypto-3 and libssl-3 are not linked dynamically anymore: https://github.com/joncinque/solana/actions/runs/8147872620/job/22269501499Fixes #34793 Fixes #32372