Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Renames fns to get_stored_account_meta() #783

Merged
merged 1 commit into from
Apr 13, 2024

Conversation

brooksprumo
Copy link

Problem

Since #774, we now have get_account(), get_stored_account(), get_stored_account_meta(), and get_account_shared_data() methods, but AppendVec::get_account() returns a StoredAccountMeta. I find this a bit confusing. If we rename get_account(), I think that would help.

Summary of Changes

Renames the methods to get_stored_account_meta() and updates callers.

@brooksprumo brooksprumo self-assigned this Apr 12, 2024
@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 91.66667% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 81.9%. Comparing base (518a5b7) to head (ee8e38e).
Report is 9 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff            @@
##           master     #783     +/-   ##
=========================================
- Coverage    81.9%    81.9%   -0.1%     
=========================================
  Files         851      851             
  Lines      231231   231341    +110     
=========================================
+ Hits       189515   189597     +82     
- Misses      41716    41744     +28     

@brooksprumo brooksprumo marked this pull request as ready for review April 13, 2024 15:19
Copy link

@jeffwashington jeffwashington left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@brooksprumo brooksprumo merged commit 8c5a33a into anza-xyz:master Apr 13, 2024
38 checks passed
@brooksprumo brooksprumo deleted the av/get_stored_account_meta branch April 13, 2024 18:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants