-
Notifications
You must be signed in to change notification settings - Fork 337
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
accounts db/refactor accounts db test - fix account storage count and alive bytes tests for hot storage #784
accounts db/refactor accounts db test - fix account storage count and alive bytes tests for hot storage #784
Conversation
|
The actual change is in the last commit. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me. Please re-request a review once #777 has been merged and this PR is rebased.
4c4701d
to
8b13d0f
Compare
No code changes. Rebased on master to pickup #777 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm. thanks!
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #784 +/- ##
=========================================
- Coverage 81.8% 81.8% -0.1%
=========================================
Files 851 851
Lines 231706 231710 +4
=========================================
- Hits 189676 189669 -7
- Misses 42030 42041 +11 |
…d alive bytes tests for hot storage (anza-xyz#784) fix account storage count and alive bytes tests for hot storage Co-authored-by: HaoranYi <[email protected]>
Problem
Add tests coverage for storage count and alive bytes tests for hot storage.
Continued on #777
Summary of Changes
Fixes #