Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

accounts db/refactor accounts db test - fix account storage count and alive bytes tests for hot storage #784

Merged

Conversation

HaoranYi
Copy link

Problem

Add tests coverage for storage count and alive bytes tests for hot storage.

Continued on #777

Summary of Changes

Fixes #

Copy link

mergify bot commented Apr 12, 2024

⚠️ The sha of the head commit of this PR conflicts with #777. Mergify cannot evaluate rules on this PR. ⚠️

@HaoranYi HaoranYi changed the title accounts db/refactor accounts db test2 fix account storage count and alive bytes tests for hot storage Apr 12, 2024
@HaoranYi
Copy link
Author

The actual change is in the last commit.
Please only review the last change if you have already reviewed #777

Copy link

@brooksprumo brooksprumo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Please re-request a review once #777 has been merged and this PR is rebased.

@HaoranYi HaoranYi self-assigned this Apr 12, 2024
@HaoranYi HaoranYi changed the title fix account storage count and alive bytes tests for hot storage accounts db/refactor accounts db test - fix account storage count and alive bytes tests for hot storage Apr 15, 2024
@HaoranYi HaoranYi force-pushed the accounts-db/refactor_accounts_db_test2 branch from 4c4701d to 8b13d0f Compare April 16, 2024 14:21
@HaoranYi HaoranYi requested a review from brooksprumo April 16, 2024 14:23
@HaoranYi
Copy link
Author

HaoranYi commented Apr 16, 2024

No code changes. Rebased on master to pickup #777
@brooksprumo @jeffwashington Please review it again. Thanks!

Copy link

@brooksprumo brooksprumo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

Copy link

@jeffwashington jeffwashington left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm. thanks!

@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 97.87234% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 81.8%. Comparing base (731d36a) to head (8b13d0f).
Report is 4 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff            @@
##           master     #784     +/-   ##
=========================================
- Coverage    81.8%    81.8%   -0.1%     
=========================================
  Files         851      851             
  Lines      231706   231710      +4     
=========================================
- Hits       189676   189669      -7     
- Misses      42030    42041     +11     

@HaoranYi HaoranYi merged commit c5a669e into anza-xyz:master Apr 16, 2024
38 checks passed
@HaoranYi HaoranYi deleted the accounts-db/refactor_accounts_db_test2 branch April 16, 2024 17:11
michaelschem pushed a commit to michaelschem/agave that referenced this pull request Apr 20, 2024
…d alive bytes tests for hot storage (anza-xyz#784)

fix account storage count and alive bytes tests for hot storage

Co-authored-by: HaoranYi <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants