Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Website] Fix Twitter button and add LinkedIn button #570

Merged
merged 4 commits into from
Jan 10, 2025

Conversation

ianmcook
Copy link
Member

@ianmcook ianmcook commented Jan 9, 2025

This fixes the broken Twitter follow button at the top of the Arrow homepage, replacing it with an X follow button. This also adds a LinkedIn follow button.

I styled these new buttons to have the same appearance as the GitHub star social buton. Unfortunately there is no clean way to achieve this. I had to inspect the page, grab some client-side-generated CSS, modify it, minify it, and include it in the HTML to style the new buttons. Not a clean fix but I think it's worth it to have the prominent broken Twitter link finally fixed.

Before:
image

After:
image

@ianmcook ianmcook changed the title [Website] Fix Twitter link and add LinkedIn link [Website] Fix Twitter button and add LinkedIn button Jan 9, 2025
@ianmcook
Copy link
Member Author

I took another look at this today to see if it would have been possible to achieve this more cleanly with Shields.io, but it turns out no, because they depend on Simple Icons which recently removed their LinkedIn icon based on an interpretation of the terms of use.

Our use of the LinkedIn logo is in compliance with the LinkedIn brand policies (1, 2) per my interpretation, although these policies contradict themselves. Quoting from the relevant sections:

if you are a LinkedIn member, you may use the “in” Logo to designate a link to your personal profile or to a Group or Company page or to promote you or your organization’s presence on LinkedIn.

While our default logo is blue, use the black or white version on layouts that are black and white only. You can also use the white version on dark backgrounds so it's easy to see.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants