Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[VL] Declare IntermediateTypes for specific agg function #3679

Merged
merged 2 commits into from
Nov 13, 2023

Conversation

liujiayi771
Copy link
Contributor

What changes were proposed in this pull request?

We should not use intermediate types' size to distinguish between different agg functions, it is not rigorous. Different agg functions may have the same number of intermediate types, but these types may be completely different.

How was this patch tested?

Exists CI.

Copy link

Thanks for opening a pull request!

Could you open an issue for this pull request on Github Issues?

https://github.com/oap-project/gluten/issues

Then could you also rename commit message and pull request title in the following format?

[GLUTEN-${ISSUES_ID}][COMPONENT]feat/fix: ${detailed message}

See also:

@liujiayi771
Copy link
Contributor Author

@rui-mo Could you please take a look?

@PHILO-HE PHILO-HE changed the title [VL] Not using intermediateTypes.size to match different agg func [VL] Declare IntermediateTypes for specific agg function Nov 13, 2023
Copy link
Contributor

@PHILO-HE PHILO-HE left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Thanks!

@PHILO-HE PHILO-HE merged commit 7cf715b into apache:main Nov 13, 2023
16 checks passed
@GlutenPerfBot
Copy link
Contributor

===== Performance report for TPCH SF2000 with Velox backend, for reference only ====

query log/native_3679_time.csv log/native_master_11_12_2023_5b632f64e_time.csv difference percentage
q1 33.75 35.06 1.302 103.86%
q2 24.53 24.58 0.051 100.21%
q3 37.73 37.43 -0.301 99.20%
q4 37.15 36.90 -0.246 99.34%
q5 69.60 71.39 1.794 102.58%
q6 7.37 7.07 -0.300 95.93%
q7 84.56 82.01 -2.549 96.99%
q8 85.44 86.35 0.919 101.08%
q9 120.39 121.45 1.060 100.88%
q10 44.47 44.24 -0.226 99.49%
q11 19.63 20.06 0.439 102.24%
q12 26.69 25.25 -1.444 94.59%
q13 47.15 46.66 -0.487 98.97%
q14 16.21 14.90 -1.306 91.95%
q15 28.67 27.08 -1.583 94.48%
q16 15.30 14.92 -0.388 97.47%
q17 100.66 99.68 -0.976 99.03%
q18 148.04 147.54 -0.503 99.66%
q19 12.98 12.97 -0.010 99.92%
q20 27.32 28.14 0.824 103.02%
q21 217.69 220.95 3.258 101.50%
q22 13.09 13.04 -0.045 99.66%
total 1218.40 1217.68 -0.717 99.94%

@GlutenPerfBot
Copy link
Contributor

===== Performance report for TPCH SF2000 with Velox backend, for reference only ====

query log/native_master_11_13_2023_time.csv log/native_master_11_12_2023_5b632f64e_time.csv difference percentage
q1 34.59 35.06 0.465 101.34%
q2 24.33 24.58 0.258 101.06%
q3 37.92 37.43 -0.492 98.70%
q4 36.03 36.90 0.877 102.43%
q5 71.38 71.39 0.014 100.02%
q6 7.19 7.07 -0.126 98.25%
q7 84.44 82.01 -2.435 97.12%
q8 86.27 86.35 0.080 100.09%
q9 122.37 121.45 -0.922 99.25%
q10 47.02 44.24 -2.777 94.09%
q11 19.75 20.06 0.313 101.58%
q12 26.95 25.25 -1.699 93.70%
q13 46.08 46.66 0.584 101.27%
q14 14.45 14.90 0.454 103.14%
q15 28.29 27.08 -1.211 95.72%
q16 15.79 14.92 -0.874 94.46%
q17 100.90 99.68 -1.216 98.79%
q18 148.71 147.54 -1.177 99.21%
q19 12.92 12.97 0.058 100.45%
q20 27.47 28.14 0.666 102.42%
q21 220.71 220.95 0.241 100.11%
q22 12.86 13.04 0.178 101.38%
total 1226.42 1217.68 -8.743 99.29%

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants