Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[GLUTEN-3719][VL] Optimize agg func match in getAggRelWithRowConstruct #3819

Merged
merged 2 commits into from
Nov 27, 2023

Conversation

liujiayi771
Copy link
Contributor

@liujiayi771 liujiayi771 commented Nov 22, 2023

What changes were proposed in this pull request?

Same as #3721

How was this patch tested?

Exists CI.

Copy link

Thanks for opening a pull request!

Could you open an issue for this pull request on Github Issues?

https://github.com/oap-project/gluten/issues

Then could you also rename commit message and pull request title in the following format?

[GLUTEN-${ISSUES_ID}][COMPONENT]feat/fix: ${detailed message}

See also:

@liujiayi771 liujiayi771 force-pushed the agg-opt branch 2 times, most recently from bf5659d to 534a319 Compare November 23, 2023 06:26
@liujiayi771 liujiayi771 changed the title [WIP][GLUTEN-3719][VL] Optimize agg func match in getAggRelWithRowConstruct [GLUTEN-3719][VL] Optimize agg func match in getAggRelWithRowConstruct Nov 24, 2023
Copy link

#3719

@liujiayi771 liujiayi771 marked this pull request as ready for review November 24, 2023 00:18
@liujiayi771
Copy link
Contributor Author

@rui-mo @PHILO-HE Could you help review?

@rui-mo rui-mo requested a review from PHILO-HE November 27, 2023 01:02
Copy link
Contributor

@PHILO-HE PHILO-HE left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@PHILO-HE PHILO-HE merged commit d04c5ec into apache:main Nov 27, 2023
16 checks passed
@GlutenPerfBot
Copy link
Contributor

===== Performance report for TPCH SF2000 with Velox backend, for reference only ====

query log/native_3819_time.csv log/native_master_11_26_2023_f456a7e86_time.csv difference percentage
q1 34.81 34.38 -0.424 98.78%
q2 24.89 24.62 -0.263 98.94%
q3 38.71 37.74 -0.962 97.51%
q4 37.65 36.67 -0.983 97.39%
q5 71.43 68.82 -2.611 96.35%
q6 7.13 7.12 -0.012 99.83%
q7 84.16 82.01 -2.150 97.45%
q8 86.68 87.72 1.044 101.20%
q9 124.07 120.79 -3.276 97.36%
q10 43.29 44.22 0.925 102.14%
q11 20.78 19.96 -0.820 96.05%
q12 25.61 28.56 2.954 111.54%
q13 46.65 46.61 -0.041 99.91%
q14 18.87 14.35 -4.521 76.04%
q15 28.57 29.15 0.583 102.04%
q16 15.75 15.41 -0.342 97.83%
q17 103.03 100.98 -2.049 98.01%
q18 150.30 145.61 -4.692 96.88%
q19 13.05 12.88 -0.167 98.72%
q20 30.40 27.79 -2.604 91.43%
q21 228.05 223.56 -4.486 98.03%
q22 13.31 13.03 -0.281 97.89%
total 1247.16 1221.98 -25.178 97.98%

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants