Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[GLUTEN-5981][CH] Make the result be null when the queried field in get_json_object is null #6001

Merged
merged 1 commit into from
Jun 7, 2024
Merged

[GLUTEN-5981][CH] Make the result be null when the queried field in get_json_object is null #6001

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 11 additions & 0 deletions ...clickhouse/src/test/scala/org/apache/gluten/execution/GlutenClickhouseFunctionSuite.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -179,4 +179,15 @@ class GlutenClickhouseFunctionSuite extends GlutenClickHouseTPCHAbstractSuite {
|""".stripMargin
)(df => checkFallbackOperators(df, 0))
}

test("GLUTEN-5981 null value from get_json_object") {
spark.sql("create table json_t1 (a string) using parquet")
spark.sql("insert into json_t1 values ('{\"a\":null}')")
runQueryAndCompare(
"""
|SELECT get_json_object(a, '$.a') is null from json_t1
|""".stripMargin
)(df => checkFallbackOperators(df, 0))
spark.sql("drop table json_t1")
}
}
2 changes: 2 additions & 0 deletions cpp-ch/local-engine/Functions/SparkFunctionGetJsonObject.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -113,6 +113,8 @@ class GetJsonObjectImpl
JSONStringSerializer serializer(*col_str);
if (elements.size() == 1) [[likely]]
{
if (elements[0].isNull())
return false;
nullable_col_str.getNullMapData().push_back(0);
if (elements[0].isString())
{
Expand Down
Loading