Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[GLUTEN-5981][CH] Make the result be null when the queried field in get_json_object is null #6001

Merged
merged 1 commit into from
Jun 7, 2024

Conversation

lgbo-ustc
Copy link
Contributor

What changes were proposed in this pull request?

(Please fill in changes proposed in this fix)

Fixes: #5981

How was this patch tested?

(Please explain how this patch was tested. E.g. unit tests, integration tests, manual tests)
unit tests

(If this patch involves UI changes, please attach a screenshot; otherwise, remove this)

Copy link

github-actions bot commented Jun 6, 2024

#5981

Copy link

github-actions bot commented Jun 6, 2024

Run Gluten Clickhouse CI

Copy link

github-actions bot commented Jun 6, 2024

Run Gluten Clickhouse CI

Copy link

github-actions bot commented Jun 6, 2024

Run Gluten Clickhouse CI

@ulysses-you ulysses-you requested review from baibaichen and zzcclp June 6, 2024 11:00
@@ -66,6 +66,11 @@ class GlutenClickhouseFunctionSuite extends GlutenClickHouseTPCHAbstractSuite {
// TODO: support default ANSI policy
.set("spark.sql.storeAssignmentPolicy", "legacy")
.set("spark.sql.warehouse.dir", warehouse)
.set(
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

set this config in the following ut case ? otherwise it can impact the other cases.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This suite is for test functions, disable unfold constant functions should be OK

Copy link

github-actions bot commented Jun 7, 2024

Run Gluten Clickhouse CI

@lgbo-ustc lgbo-ustc changed the title [GLUTEN-5981][CH] Make the result be null when the queried field is null [GLUTEN-5981][CH] Make the result be null when the queried field in get_json_object is null Jun 7, 2024
Copy link
Contributor

@zzcclp zzcclp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zzcclp zzcclp merged commit 85e8619 into apache:main Jun 7, 2024
8 checks passed
@GlutenPerfBot
Copy link
Contributor

===== Performance report for TPCDS SF2000 with Velox backend, for reference only ====

query log/native_master_06_07_2024_time.csv log/native_master_06_05_2024_54aeb010d_time.csv difference percentage
q1 14.79 14.95 0.159 101.07%
q2 15.94 15.33 -0.610 96.17%
q3 4.59 4.37 -0.221 95.19%
q4 61.52 65.61 4.091 106.65%
q5 8.09 6.32 -1.767 78.16%
q6 3.79 3.85 0.059 101.55%
q7 4.28 8.91 4.622 207.86%
q8 3.32 5.65 2.334 170.29%
q9 17.56 16.14 -1.423 91.90%
q10 10.42 9.71 -0.701 93.27%
q11 34.63 35.12 0.482 101.39%
q12 1.47 2.56 1.089 174.16%
q13 5.43 6.67 1.238 122.81%
q14a 45.37 41.01 -4.357 90.40%
q14b 38.59 41.81 3.224 108.35%
q15 2.54 3.81 1.277 150.34%
q16 41.85 38.16 -3.692 91.18%
q17 4.37 4.50 0.127 102.91%
q18 7.09 5.99 -1.109 84.37%
q19 1.95 3.15 1.198 161.56%
q20 2.77 1.42 -1.357 51.09%
q21 1.07 1.02 -0.048 95.54%
q22 9.56 8.47 -1.091 88.58%
q23a 81.89 79.88 -2.011 97.54%
q23b 99.25 102.22 2.970 102.99%
q24a 77.00 77.29 0.288 100.37%
q24b 70.09 69.19 -0.901 98.71%
q25 3.92 4.12 0.203 105.17%
q26 5.51 2.67 -2.838 48.47%
q27 8.40 2.98 -5.416 35.50%
q28 21.93 24.76 2.837 112.94%
q29 6.71 6.74 0.035 100.52%
q30 4.27 4.09 -0.175 95.90%
q31 5.78 5.92 0.136 102.35%
q32 1.04 1.07 0.032 103.05%
q33 4.66 4.76 0.105 102.25%
q34 4.50 4.90 0.400 108.90%
q35 10.31 6.52 -3.793 63.22%
q36 3.15 3.20 0.046 101.46%
q37 3.97 3.84 -0.127 96.79%
q38 11.80 11.96 0.156 101.32%
q39a 3.39 3.28 -0.117 96.55%
q39b 2.69 2.88 0.190 107.06%
q40 3.46 3.46 0.001 100.03%
q41 1.93 0.71 -1.216 36.92%
q42 0.89 0.80 -0.082 90.69%
q43 3.67 3.38 -0.292 92.03%
q44 6.90 6.81 -0.085 98.76%
q45 3.38 3.48 0.102 103.02%
q46 2.89 2.96 0.067 102.30%
q47 15.10 14.31 -0.787 94.79%
q48 4.43 4.21 -0.226 94.90%
q49 7.30 9.24 1.942 126.61%
q50 20.57 21.75 1.179 105.73%
q51 8.23 8.56 0.328 103.99%
q52 0.86 1.01 0.155 118.02%
q53 1.79 1.76 -0.029 98.35%
q54 3.09 3.21 0.115 103.71%
q55 0.92 0.97 0.045 104.84%
q56 4.31 5.47 1.162 126.97%
q57 9.76 9.02 -0.743 92.39%
q58 2.66 3.52 0.857 132.25%
q59 13.68 17.30 3.620 126.47%
q60 4.81 4.96 0.155 103.22%
q61 5.19 5.42 0.230 104.43%
q62 3.65 4.55 0.898 124.61%
q63 1.88 1.96 0.083 104.42%
q64 47.98 49.54 1.556 103.24%
q65 15.81 13.49 -2.319 85.33%
q66 2.92 3.19 0.276 109.48%
q67 351.25 353.70 2.445 100.70%
q68 4.11 3.54 -0.563 86.30%
q69 6.42 6.01 -0.411 93.60%
q70 8.46 10.18 1.716 120.27%
q71 2.17 2.21 0.039 101.79%
q72 193.17 188.77 -4.402 97.72%
q73 2.14 2.26 0.115 105.35%
q74 21.11 21.18 0.068 100.32%
q75 21.31 21.27 -0.030 99.86%
q76 9.30 7.34 -1.961 78.92%
q77 1.86 1.71 -0.151 91.91%
q78 37.33 40.34 3.010 108.06%
q79 3.30 3.41 0.113 103.43%
q80 11.14 10.62 -0.520 95.33%
q81 6.49 4.42 -2.062 68.21%
q82 6.27 6.15 -0.118 98.12%
q83 1.53 3.80 2.275 248.97%
q84 3.00 3.08 0.086 102.86%
q85 6.88 6.39 -0.499 92.75%
q86 3.19 3.28 0.092 102.90%
q87 12.25 15.50 3.251 126.54%
q88 16.77 16.70 -0.067 99.60%
q89 2.81 2.76 -0.051 98.18%
q90 2.93 3.38 0.445 115.16%
q91 5.78 2.57 -3.216 44.41%
q92 1.16 1.14 -0.019 98.37%
q93 29.28 30.18 0.904 103.09%
q94 21.25 21.03 -0.221 98.96%
q9 86.32 80.18 -6.133 92.89%
q5 2.23 2.42 0.194 108.70%
q96 11.99 15.35 3.356 127.98%
q97 2.10 1.94 -0.165 92.16%
q98 8.83 8.29 -0.538 93.91%
q99 8.83 8.29 -0.538 93.91%
total 1873.42 1872.93 -0.483 99.97%

@GlutenPerfBot
Copy link
Contributor

===== Performance report for TPCH SF2000 with Velox backend, for reference only ====

query log/native_master_06_07_2024_time.csv log/native_master_06_05_2024_54aeb010d_time.csv difference percentage
q1 34.74 34.06 -0.687 98.02%
q2 23.82 23.10 -0.717 96.99%
q3 37.27 36.59 -0.683 98.17%
q4 30.13 34.70 4.567 115.16%
q5 70.45 69.24 -1.219 98.27%
q6 7.45 7.84 0.385 105.17%
q7 83.57 81.42 -2.149 97.43%
q8 86.74 87.21 0.469 100.54%
q9 121.95 119.35 -2.595 97.87%
q10 45.15 45.23 0.079 100.18%
q11 19.51 22.65 3.146 116.13%
q12 26.76 25.04 -1.722 93.57%
q13 39.39 36.70 -2.698 93.15%
q14 20.54 17.35 -3.190 84.47%
q15 31.52 29.97 -1.555 95.07%
q16 13.65 15.12 1.466 110.74%
q17 103.56 104.42 0.866 100.84%
q18 145.21 144.82 -0.395 99.73%
q19 14.70 14.62 -0.078 99.47%
q20 28.92 26.48 -2.437 91.57%
q21 262.04 266.79 4.751 101.81%
q22 14.56 12.29 -2.273 84.38%
total 1261.63 1254.96 -6.669 99.47%

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[CH] DIff result for get_json_object to get null value
3 participants