[GLUTEN-6600][VL] Disable date type in window range frame support #6637
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for opening a pull request! Could you open an issue for this pull request on Github Issues? https://github.com/apache/incubator-gluten/issues Then could you also rename commit message and pull request title in the following format? See also: |
|
Run Gluten Clickhouse CI |
1 similar comment
|
Run Gluten Clickhouse CI |
JkSelf
changed the title
|
LGTM |
|
Seems failed tests are related |
|
Run Gluten Clickhouse CI |
zml1206
approved these changes
Jul 30, 2024
| @@ -347,7 +347,7 @@ object VeloxBackendSettings extends BackendSettingsApi { | |||
| orderSpec.foreach( | |||
| order => | |||
| order.dataType match { | |||
| case ByteType | ShortType | IntegerType | LongType | DateType => | |||
| case ByteType | ShortType | IntegerType | LongType => | |||
| case _ => | |||
| throw new GlutenNotSupportException( | |||
| "Only integral type & date type are" + | |||
There was a problem hiding this comment.
@zml1206 Good catch. Updated.
|
Run Gluten Clickhouse CI |
Yes. Fixed. |
ulysses-you
approved these changes
Jul 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
To support range frames, we need to add a pre-project before the window to calculate the range frame's value. If the key in the order by clause is of date type, using Add(orderSpec.child, bound) will result in the column's attribute being Unresolved, because the data types on both sides of
Addare inconsistent. We try to useDateAddfor date types here to perform the calculation, and the pre-project can work. However, the post-project will throw same error because we have rewritten the frame in the Window to be of date type, but Spark's frame type does not support DateType.How was this patch tested?
Adding new unit tests.
(If this patch involves UI changes, please attach a screenshot; otherwise, remove this)