Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[GLUTEN-7203][CORE] Make push down filter to scan as a individual rule #7215

Merged
merged 6 commits into from
Sep 18, 2024

Conversation

zml1206
Copy link
Contributor

@zml1206 zml1206 commented Sep 12, 2024

What changes were proposed in this pull request?

Fixes: #7203

How was this patch tested?

CI

@zml1206 zml1206 marked this pull request as draft September 12, 2024 13:26
@github-actions github-actions bot added CORE works for Gluten Core VELOX CLICKHOUSE labels Sep 12, 2024
Copy link

#7203

@zml1206 zml1206 changed the title [GLUTEN-7203][Core] Make push down filter to scan as a individual rule [GLUTEN-7203][CORE] Make push down filter to scan as a individual rule Sep 12, 2024
Copy link

Run Gluten Clickhouse CI

Copy link

Run Gluten Clickhouse CI

Copy link

Run Gluten Clickhouse CI

1 similar comment
Copy link

Run Gluten Clickhouse CI

@zml1206 zml1206 marked this pull request as ready for review September 13, 2024 06:39
@zml1206
Copy link
Contributor Author

zml1206 commented Sep 13, 2024

cc @zhztheplayer thank you.

Copy link

Run Gluten Clickhouse CI

1 similar comment
Copy link

Run Gluten Clickhouse CI

@FelixYBW
Copy link
Contributor

Can you resolve conflicts?

Copy link

Run Gluten Clickhouse CI

Copy link
Member

@zhztheplayer zhztheplayer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Roughly went through the code and LGTM overall

@zhztheplayer zhztheplayer merged commit 9c5f817 into apache:main Sep 18, 2024
44 checks passed
@GlutenPerfBot
Copy link
Contributor

===== Performance report for TPCDS SF2000 with Velox backend, for reference only ====

query log/native_master_09_18_2024_time.csv log/native_master_08_31_2024_d785693e59_time.csv difference percentage
q1 13.99 14.84 0.845 106.04%
q2 15.24 14.87 -0.367 97.59%
q3 2.98 4.36 1.380 146.36%
q4 70.76 70.04 -0.722 98.98%
q5 10.57 7.84 -2.737 74.11%
q6 3.63 2.57 -1.055 70.93%
q7 5.96 6.56 0.598 110.03%
q8 5.11 3.45 -1.664 67.42%
q9 23.55 25.40 1.857 107.89%
q10 9.67 10.72 1.050 110.86%
q11 36.63 38.50 1.869 105.10%
q12 1.45 2.36 0.908 162.48%
q13 6.46 6.53 0.069 101.06%
q14a 46.48 47.34 0.861 101.85%
q14b 41.41 41.47 0.064 100.15%
q15 3.42 2.98 -0.437 87.23%
q16 47.15 45.28 -1.868 96.04%
q17 4.67 5.03 0.363 107.77%
q18 6.94 6.96 0.017 100.24%
q19 2.00 2.06 0.060 103.01%
q20 1.35 1.52 0.171 112.73%
q21 1.11 1.20 0.091 108.16%
q22 7.76 8.12 0.359 104.63%
q23a 105.32 103.84 -1.475 98.60%
q23b 127.79 131.16 3.368 102.64%
q24a 98.41 115.11 16.705 116.98%
q24b 109.57 104.89 -4.680 95.73%
q25 4.09 3.96 -0.132 96.76%
q26 3.38 3.18 -0.200 94.07%
q27 3.99 5.14 1.145 128.69%
q28 30.34 34.58 4.236 113.96%
q29 11.83 11.38 -0.449 96.21%
q30 4.76 5.06 0.297 106.24%
q31 7.00 7.32 0.311 104.45%
q32 1.20 1.22 0.018 101.46%
q33 4.67 4.16 -0.509 89.10%
q34 3.59 3.80 0.209 105.82%
q35 8.57 8.31 -0.259 96.98%
q36 5.41 4.61 -0.797 85.27%
q37 4.99 4.60 -0.383 92.31%
q38 13.50 14.78 1.279 109.48%
q39a 3.18 3.61 0.436 113.72%
q39b 2.57 3.37 0.803 131.26%
q40 4.32 4.39 0.077 101.79%
q41 0.59 0.61 0.023 103.93%
q42 0.89 0.83 -0.057 93.54%
q43 4.26 4.51 0.255 106.00%
q44 11.83 11.31 -0.520 95.61%
q45 4.19 3.36 -0.828 80.21%
q46 4.13 3.84 -0.292 92.93%
q47 17.55 19.33 1.777 110.12%
q48 5.20 5.29 0.085 101.63%
q49 7.77 10.52 2.758 135.52%
q50 29.11 22.95 -6.159 78.84%
q51 9.28 9.89 0.613 106.60%
q52 1.01 1.13 0.117 111.57%
q53 2.12 2.48 0.351 116.52%
q54 3.71 4.14 0.430 111.58%
q55 1.03 1.02 -0.004 99.64%
q56 4.10 4.22 0.122 102.98%
q57 11.10 10.65 -0.448 95.96%
q58 2.61 2.48 -0.136 94.80%
q59 11.00 11.12 0.126 101.15%
q60 4.16 4.21 0.053 101.27%
q61 4.14 4.13 -0.007 99.83%
q62 4.55 4.35 -0.200 95.60%
q63 2.37 2.50 0.130 105.49%
q64 60.71 63.66 2.946 104.85%
q65 16.66 18.37 1.710 110.27%
q66 4.08 4.16 0.086 102.11%
q67 388.00 395.32 7.320 101.89%
q68 3.64 3.72 0.079 102.16%
q69 7.89 6.53 -1.361 82.75%
q70 10.42 11.82 1.403 113.47%
q71 2.27 2.55 0.288 112.70%
q72 212.46 217.73 5.275 102.48%
q73 2.30 2.42 0.120 105.24%
q74 22.89 23.58 0.687 103.00%
q75 25.70 26.46 0.764 102.97%
q76 11.80 11.64 -0.166 98.59%
q77 2.09 2.27 0.178 108.50%
q78 49.03 49.86 0.825 101.68%
q79 3.72 3.93 0.210 105.65%
q80 11.22 12.39 1.177 110.49%
q81 4.58 4.93 0.358 107.83%
q82 6.56 7.00 0.449 106.85%
q83 2.05 1.71 -0.345 83.19%
q84 2.66 3.11 0.452 116.99%
q85 6.91 8.26 1.351 119.54%
q86 4.03 4.04 0.010 100.24%
q87 13.55 14.82 1.266 109.34%
q88 17.24 21.85 4.607 126.72%
q89 3.10 3.89 0.784 125.29%
q90 2.80 3.29 0.493 117.63%
q91 2.40 2.73 0.327 113.62%
q92 1.27 1.45 0.180 114.12%
q93 44.23 40.97 -3.266 92.62%
q94 25.65 24.49 -1.156 95.49%
q9 89.44 89.84 0.396 100.44%
q5 2.50 3.21 0.716 128.67%
q96 17.59 17.28 -0.301 98.29%
q97 1.96 2.00 0.048 102.44%
q98 11.72 9.89 -1.837 84.33%
q99 11.72 9.89 -1.837 84.33%
total 2168.54 2214.52 45.974 102.12%

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLICKHOUSE CORE works for Gluten Core VELOX
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[CORE] Make push down filter to scan as a individual rule
4 participants