[GLUTEN-7913][CORE] Flip dependency direction for gluten-uniffle #8242
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Run Gluten Clickhouse CI on x86 |
jackylee-ch
approved these changes
Dec 16, 2024
zhztheplayer
force-pushed
the
wip-flip-uniffle
branch
from
5775e7f to
a6bc08b
Compare
|
Run Gluten Clickhouse CI on x86 |
zhztheplayer
force-pushed
the
wip-flip-uniffle
branch
from
a6bc08b to
4a23262
Compare
|
Run Gluten Clickhouse CI on x86 |
|
Rebased to latest main and will merge after CI passes. Thank you for the review @jackylee-ch Feel free to comment / discuss at any time @summaryzb |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#7913
Make Maven module backends-velox depend on gluten-uniffle than the opposite, to make sure the common source code and UT code (particularly uniffleSuite at the moment) to be accessible from other backend modules.
The new folder backends-velox/src-uniffle is added for placing code that relate to Velox+uniffle support.
TODO in subsequent PRs:
Enable Maven code linters for backends-velox/src-uniffle
Note: This makes gluten-uniffle an empty module since all the resident code in the module was written for Velox backend and be moved to backends-velox/src-uniffle in this PR. Though the module
gluten-uniffleis still kept for future use.