Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[VL] Allow shared dependencies for lib GCS #8251

Merged
merged 1 commit into from
Dec 17, 2024

Conversation

PHILO-HE
Copy link
Contributor

@PHILO-HE PHILO-HE commented Dec 17, 2024

What changes were proposed in this pull request?

This pr simply removes the setting for CMAKE_FIND_LIBRARY_SUFFIXES before finding lib GCS.

@github-actions github-actions bot added the VELOX label Dec 17, 2024
Copy link

Thanks for opening a pull request!

Could you open an issue for this pull request on Github Issues?

https://github.com/apache/incubator-gluten/issues

Then could you also rename commit message and pull request title in the following format?

[GLUTEN-${ISSUES_ID}][COMPONENT]feat/fix: ${detailed message}

See also:

@PHILO-HE
Copy link
Contributor Author

@majetideepak

Copy link
Collaborator

@majetideepak majetideepak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @PHILO-HE

@PHILO-HE PHILO-HE marked this pull request as ready for review December 17, 2024 13:35
@FelixYBW FelixYBW merged commit 8f71966 into apache:main Dec 17, 2024
47 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants