-
Notifications
You must be signed in to change notification settings - Fork 94
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MINIFICPP-2133 Add TLS 1.3 support #1600
Conversation
Can we collect the affected parts, and which SSL/TLS versions are accepted in each case? I think we should aim to only accept TLS 1.2 and 1.3 in all cases, unless the user explicitly allows deprecated/insecure versions. |
This is the case currently. We only support TLS 1.2 and 1.3, only HTTPClient has the option to set a specific or a minimum/maxiumum version that would allow the use of a legacy TLS version. |
f0caa49
to
029fd08
Compare
b7920cf
to
3225df9
Compare
029fd08
to
85ec9ef
Compare
3225df9
to
2c9e2c5
Compare
f518ecb
to
4638af0
Compare
2c9e2c5
to
195fe30
Compare
HTTPClient
stream truncated
errors: https://stackoverflow.com/questions/25587403/boost-asio-ssl-async-shutdown-always-finishes-with-an-errorDepends on #1599
https://issues.apache.org/jira/browse/MINIFICPP-2133
Thank you for submitting a contribution to Apache NiFi - MiNiFi C++.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
For all changes:
Is there a JIRA ticket associated with this PR? Is it referenced
in the commit message?
Does your PR title start with MINIFICPP-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.
Has your PR been rebased against the latest commit within the target branch (typically main)?
Is your initial contribution a single, squashed commit?
For code changes:
For documentation related changes:
Note:
Please ensure that once the PR is submitted, you check GitHub Actions CI results for build issues and submit an update to your PR as soon as possible.