Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Raspberry Pico 2 porting #14831

Merged
merged 9 commits into from
Nov 20, 2024
Merged

Raspberry Pico 2 porting #14831

merged 9 commits into from
Nov 20, 2024

Conversation

PeterBee97
Copy link
Contributor

@PeterBee97 PeterBee97 commented Nov 17, 2024 •
edited
Loading

Summary

Porting of RP2350 platform continuing @casaroli 's work #13305. Still have many stuff to test and fix, but most things are working!

Impact

  • drivers:

    • timerisr - using sysclock -- need to switch to TICK
    • UART
    • led/gpio/button/ws2812
    • usbdev serial -- somewhat
    • uniqueid
    • PSRAM
    • ADC
    • Flash boot
    • I2C
    • usbmsc
    • usb composite
    • AON timer (RTC)
    • watchdog
    • I2S
    • SPI
    • spidev
    • pio
    • SMP
    • MTD

  • boards

    • Raspberry Pi Pico 2
    • Pimoroni tiny2350
    • Pimonori Pico 2 Plus

  • chore

    • register definition generate / reformat
    • format all source files

Impact

New potentially very popular boards supported in NuttX.

Testing

Manual testing with the boards on hand.

casaroli and others added 8 commits November 17, 2024 16:50
@casaroli @PeterBee97
rp23xx: add pico-sdk files
7000af2 
These files were copied from a config of pico-sdk 2.0.0.

They provide struct address mapped access to peripherals, along
with register definitions. It also provides some compiler helpers
that are partially used by the port.
@casaroli @PeterBee97
doc(rp23xx): add arch and board documentation
e43a328
@casaroli @PeterBee97
board(rp23xx): add Raspberry Pi Pico 2
d990c72
@casaroli @PeterBee97
arch(rp23xx): add files
9bd3329
@casaroli @PeterBee97
fixup! board(rp23xx): add Raspberry Pi Pico 2
6fff0bf
@casaroli @PeterBee97
board(rp23xx): add Pimoroni Pico 2 Plus
d14fa84
@casaroli @PeterBee97
uf2
020965f
@PeterBee97
refine driver
e62ef0d 
Signed-off-by: Peter Bee <[email protected]>
@github-actions github-actions bot added Area: Documentation Improvements or additions to documentation Area: Tooling Arch: arm Issues related to ARM (32-bit) architecture Board: arm Size: XL The size of the change in this PR is very large. Consider breaking down the PR into smaller pieces. labels Nov 17, 2024
@github-actions GitHub Actions
Copy link

This PR exceeds the recommended size of 1000 lines. Please make sure you are NOT addressing multiple issues with one PR. Note this PR might be rejected due to its size.

@PeterBee97 PeterBee97 mentioned this pull request Nov 17, 2024
Draft
24 tasks
@github-actions GitHub Actions
Copy link

This PR exceeds the recommended size of 1000 lines. Please make sure you are NOT addressing multiple issues with one PR. Note this PR might be rejected due to its size.

@PeterBee97
Copy link
Contributor Author

The PSRAM part is removed for now since I don't have a Pimoroni board at hand to test. Calling for help :)

@hartmannathan
Copy link
Contributor

The PSRAM part is removed for now since I don't have a Pimoroni board at hand to test. Calling for help :)

@PeterBee97 you could try writing to the mailing list and asking if someone has the board.

hartmannathan
hartmannathan reviewed Nov 17, 2024
View reviewed changes
Documentation/platforms/arm/rp23xx/boards/raspberrypi-pico-2/README.txt Outdated Show resolved Hide resolved
Documentation/platforms/arm/rp23xx/index.rst Outdated Show resolved Hide resolved
Documentation/platforms/arm/rp23xx/index.rst Outdated Show resolved Hide resolved
Documentation/platforms/arm/rp23xx/index.rst Outdated Show resolved Hide resolved
arch/arm/include/rp23xx/i2c_slave.h Outdated Show resolved Hide resolved
arch/arm/include/rp23xx/i2c_slave.h Outdated Show resolved Hide resolved
@github-actions GitHub Actions
Copy link

This PR exceeds the recommended size of 1000 lines. Please make sure you are NOT addressing multiple issues with one PR. Note this PR might be rejected due to its size.

@github-actions GitHub Actions
Copy link

This PR exceeds the recommended size of 1000 lines. Please make sure you are NOT addressing multiple issues with one PR. Note this PR might be rejected due to its size.

@github-actions GitHub Actions
Copy link

This PR exceeds the recommended size of 1000 lines. Please make sure you are NOT addressing multiple issues with one PR. Note this PR might be rejected due to its size.

1 similar comment
@github-actions GitHub Actions
Copy link

This PR exceeds the recommended size of 1000 lines. Please make sure you are NOT addressing multiple issues with one PR. Note this PR might be rejected due to its size.

@acassis
Copy link
Contributor

acassis commented Nov 18, 2024

@PeterBee97 please take a look at this error:

arm-none-eabi-ld: warning: /github/workspace/sources/nuttx/nuttx has a LOAD segment with RWX permissions
arm-none-eabi-ld: /github/workspace/sources/nuttx/staging/libsched.a(nx_bringup.o): in function `nx_romfsetc':
/github/workspace/sources/nuttx/sched/init/nx_bringup.c:276:(.text.nx_bringup+0xa0): undefined reference to `romfs_img_len'
arm-none-eabi-ld: /github/workspace/sources/nuttx/sched/init/nx_bringup.c:276:(.text.nx_bringup+0xa4): undefined reference to `romfs_img'
make[1]: *** [Makefile:212: nuttx] Error 1
make: *** [tools/Unix.mk:551: nuttx] Error 2
make: Target 'all' not remade because of errors.
/github/workspace/sources/nuttx/tools/testbuild.sh: line 385: /github/workspace/sources/nuttx/../nuttx/nuttx.manifest: No such file or directory
  Normalize raspberrypi-pico-2/spisd
HEAD detached at pull/14831/merge
Untracked files:
  (use "git add <file>..." to include in what will be committed)
	boards/arm/rp23xx/raspberrypi-pico-2/scripts/memmap_default.ld.tmp

@github-actions GitHub Actions
Copy link

This PR exceeds the recommended size of 1000 lines. Please make sure you are NOT addressing multiple issues with one PR. Note this PR might be rejected due to its size.

@github-actions GitHub Actions
Copy link

This PR exceeds the recommended size of 1000 lines. Please make sure you are NOT addressing multiple issues with one PR. Note this PR might be rejected due to its size.

@xiaoxiang781216
Copy link
Contributor

can we fuse the last three patches into the previous patches.

@github-actions GitHub Actions
Copy link

This PR exceeds the recommended size of 1000 lines. Please make sure you are NOT addressing multiple issues with one PR. Note this PR might be rejected due to its size.

@PeterBee97
Copy link
Contributor Author

can we fuse the last three patches into the previous patches.

Sure. Squashed

@acassis acassis merged commit c0f776d into apache:master Nov 20, 2024
28 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hartmannathan hartmannathan hartmannathan left review comments

@xiaoxiang781216 xiaoxiang781216 xiaoxiang781216 approved these changes

@acassis acassis acassis approved these changes

Assignees
No one assigned
Labels
Arch: arm Issues related to ARM (32-bit) architecture Area: Documentation Improvements or additions to documentation Area: Tooling Board: arm Size: XL The size of the change in this PR is very large. Consider breaking down the PR into smaller pieces.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@PeterBee97 @hartmannathan @acassis @xiaoxiang781216 @casaroli