Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: GHA frontend builds fail when frontends hasn't changed #31742

Merged
merged 2 commits into from
Jan 8, 2025

Conversation

mistercrunch
Copy link
Member

@mistercrunch mistercrunch commented Jan 8, 2025

I just merged #31490 and realized it fails when no frontend changes are found. It will run the first workflow and fail on subsequent.

This PR makes it such that the first workflow emits an output to tell the other workflows to skip if needed.

To test it, I had to remove the regex in scripts/change_detector.py that looks whether the specific GHA I'm altering here has been changed and it skipped as expected:

Screenshot 2025-01-07 at 5 15 52 PM

... and reenabled the rule after testing

I just merged #31490 and realize
it fails when no frontend changes are found. It will run the first
workflow and fail on subsequent.

This PR makes it such that the first workflow emits an output to tell
the other workflows to skip if needed.
@github-actions github-actions bot added the github_actions Pull requests that update GitHub Actions code label Jan 8, 2025
Copy link

@korbit-ai korbit-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've completed my review and didn't find any issues... but I did find this frog.

           .--._.--.
          ( O     O )
          /   . .   \
         .`._______.'.
        /(           )\
      _/  \  \   /  /  \_
   .~   `  \  \ /  /  '   ~.
  {    -.   \  V  /   .-    }
_ _`.    \  |  |  |  /    .'_ _
>_       _} |  |  | {_       _<
 /. - ~ ,_-'  .^.  `-_, ~ - .\
         '-'|/   \|`-`

Need a new review? Comment /korbit-review on this PR and I'll review your latest changes.

Korbit Guide: Usage and Customization

Interacting with Korbit

  • You can manually ask Korbit to review your PR using the /korbit-review command in a comment at the root of your PR.
  • You can ask Korbit to generate a new PR description using the /korbit-generate-pr-description command in any comment on your PR.
  • Too many Korbit comments? I can resolve all my comment threads if you use the /korbit-resolve command in any comment on your PR.
  • Chat with Korbit on issues we post by tagging @korbit-ai in your reply.
  • Help train Korbit to improve your reviews by giving a 👍 or 👎 on the comments Korbit posts.

Customizing Korbit

  • Check out our docs on how you can make Korbit work best for you and your team.
  • Customize Korbit for your organization through the Korbit Console.

Current Korbit Configuration

General Settings
Setting Value
Review Schedule Automatic excluding drafts
Max Issue Count 10
Automatic PR Descriptions
Issue Categories
Category Enabled
Naming
Database Operations
Documentation
Logging
Error Handling
Systems and Environment
Objects and Data Structures
Readability and Maintainability
Asynchronous Processing
Design Patterns
Third-Party Libraries
Performance
Security
Functionality

Feedback and Support

Note

Korbit Pro is free for open source projects 🎉

Looking to add Korbit to your team? Get started with a free 2 week trial here

@mistercrunch mistercrunch merged commit d5a4815 into master Jan 8, 2025
81 of 99 checks passed
@mistercrunch mistercrunch deleted the fix_frontend_builds branch January 8, 2025 01:33
hainenber pushed a commit to hainenber/superset that referenced this pull request Jan 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
github_actions Pull requests that update GitHub Actions code preset-io size/S
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants