Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: GHA frontend builds fail when frontends hasn't changed #31742

Merged
merged 2 commits into from
Jan 8, 2025
Merged

fix: GHA frontend builds fail when frontends hasn't changed #31742

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0c17469
fix: GHA frontend builds fail when frontends hasn't changed
mistercrunch Jan 8, 2025
3f92aaa
missed a key
mistercrunch Jan 8, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 7 additions & 5 deletions .github/workflows/superset-frontend.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,8 @@ env:
jobs:
frontend-build:
runs-on: ubuntu-24.04
outputs:
should-run: ${{ steps.check.outputs.frontend }}
steps:
- name: Checkout Code
uses: actions/checkout@v4
Expand Down Expand Up @@ -57,7 +59,7 @@ jobs:

sharded-jest-tests:
needs: frontend-build
if: needs.frontend-build.result == 'success'
if: needs.frontend-build.outputs.should-run == 'true'
strategy:
matrix:
shard: [1, 2, 3, 4, 5, 6, 7, 8]
Expand Down Expand Up @@ -89,7 +91,7 @@ jobs:

report-coverage:
needs: [sharded-jest-tests]
if: needs.frontend-build.result == 'success'
if: needs.frontend-build.outputs.should-run == 'true'
runs-on: ubuntu-24.04
steps:
- name: Download Coverage Artifacts
Expand All @@ -115,7 +117,7 @@ jobs:

core-cover:
needs: frontend-build
if: needs.frontend-build.result == 'success'
if: needs.frontend-build.outputs.should-run == 'true'
runs-on: ubuntu-24.04
steps:
- name: Download Docker Image Artifact
Expand All @@ -133,7 +135,7 @@ jobs:

lint-frontend:
needs: frontend-build
if: needs.frontend-build.result == 'success'
if: needs.frontend-build.outputs.should-run == 'true'
runs-on: ubuntu-24.04
steps:
- name: Download Docker Image Artifact
Expand All @@ -156,7 +158,7 @@ jobs:

validate-frontend:
needs: frontend-build
if: needs.frontend-build.result == 'success'
if: needs.frontend-build.outputs.should-run == 'true'
runs-on: ubuntu-24.04
steps:
- name: Download Docker Image Artifact
Expand Down
Loading