Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Companion fix for apigee/apigee-client-php/pull/334 #1019

Merged
merged 1 commit into from
Jan 8, 2024

Conversation

mxr576
Copy link
Contributor

@mxr576 mxr576 commented Jan 3, 2024

Add missing try-catch block around GCE authentication availability check.

Follow up tasks:

Copy link

codecov bot commented Jan 3, 2024

Codecov Report

Attention: 8 lines in your changes are missing coverage. Please review.

Comparison is base (b7313f7) 44.22% compared to head (2ce516d) 44.22%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff            @@
##                3.x    #1019   +/-   ##
=========================================
  Coverage     44.22%   44.22%           
  Complexity     3028     3028           
=========================================
  Files           341      341           
  Lines         11083    11083           
=========================================
  Hits           4901     4901           
  Misses         6182     6182           
Files Coverage Δ
src/Plugin/KeyInput/ApigeeAuthKeyInput.php 0.00% <0.00%> (ø)

Copy link
Collaborator

@shishir-intelli shishir-intelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Add missing try-catch block around GCE authentication availability check.
@shishir-intelli shishir-intelli merged commit 258117c into apigee:3.x Jan 8, 2024
5 checks passed
@shishir-intelli shishir-intelli added this to the 3.0.5 milestone Jan 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

Successfully merging this pull request may close these issues.

2 participants