-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change exceptions used to catch failed GCE authentication #334
Conversation
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## 3.x #334 +/- ##
=========================================
Coverage 87.60% 87.60%
Complexity 1750 1750
=========================================
Files 349 349
Lines 4704 4704
=========================================
Hits 4121 4121
Misses 583 583
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Maybe this approach combines best from both worlds, isAvailable() should only fail with |
Add missing try-catch block around GCE authentication availability check.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Add missing try-catch block around GCE authentication availability check.
Closes #333