[compiler][closures] Wire compilation down to binary format and fix bugs #15931
+10,139
−1,623
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
⏱️ 25m total CI duration on this PR
🚨 1 job on the last run was significantly faster/slower than expected
|
This was referenced Feb 11, 2025
|
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
This stack of pull requests is managed by Graphite. Learn more about stacking. |
16 tasks
wrwg
force-pushed
the
wrwg/closure-il
branch
2 times, most recently
from
f89ec64 to
db0c585
Compare
This implements closures in the RTL bytecode ("stackless bytecode") and wires them down in the compilation chain to Move bytecode. No actual execution of the codes happens, but bytecode verification.
A few issues found in closure compiler and the bytecode verifier are fixed, as well as missing pieces in the stack extended (like the disassembler).
Existing tests (after modification of sources) now pass also bytecode verification.
wrwg
force-pushed
the
wrwg/closure-il
branch
from
db0c585 to
383e4de
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This implements closures in the RTL bytecode ("stackless bytecode") and wires them down in the compilation chain to Move bytecode. No actual execution of the codes happens, but bytecode verification.
A few issues found in closure compiler and the bytecode verifier are fixed, as well as missing pieces in the stack extended (like the disassembler).
How Has This Been Tested?
Existing tests (after modification of sources) now pass also bytecode verification.
Type of Change
Which Components or Systems Does This Change Impact?