feat: gatekeeper repo ambiguous prefix #327
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
the docs generator didn't pick this up BTW, I'm not sure why |
|
FYI @yakirk |
|
BTW I also wasn't sure if this is a KSV or KUBE check. what's the difference? |
nikpivkin
reviewed
Jan 27, 2025
nikpivkin
reviewed
Jan 27, 2025
nikpivkin
reviewed
Jan 27, 2025
|
about the docs - this will be covered in a blog post (which is blocked by this PR), i will add a link after it publishes. |
Good catch, I don't think they are different it's probably just not organized. However, changing IDs will cause breakage. But there are two options:
|
simar7
approved these changes
Jan 29, 2025
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Gatekeeper does a prefix-match (startswith) to check if a repo is allowed. this can be leveraged by attackers who create repos with simlar prefix which can bypass the prefix matching (see tests for examples)
related: open-policy-agent/gatekeeper-library#616