-
-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add basePath as config option #55
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your contribution @myasteiner 😊
Please add a test about this feature, you can use a similar example of this:
next-translate-plugin/__tests__/index.test.js
Lines 25 to 33 in c4a9485
describe('nextTranslate', () => { | |
describe('nextTranslate -> pagesInDir', () => { | |
test('should detect correctly the appFolder and pagesFolder depending on the pagesInDir', () => { | |
fs.readdirSync.mockImplementationOnce(() => []) | |
const config = nextTranslate({}) | |
expect(config.webpack({})).toEqual( | |
expect.objectContaining({ |
and check the final next config is without the nextTranslate
.
@myasteiner ping 🏓 🤗 |
🤗 🏓 |
Is it possible to takeover? |
when the changes I have mentioned in the comments have been made. If we see that @myasteiner does not have time, we would implement it in another PR. |
Sorry, I would do that if the coming weeks I've nobody has time before. |
876285a
to
28bceae
Compare
28bceae
to
b2fcecf
Compare
I've updated the PR does it look good for you? Btw, can we maybe also add an option to opt-out of getStaticProps per default? @aralroca |
Hey @aralroca , would you mind taking a look at this PR? This is something that's a blocker for upgrading dependencies which bring very nice additions :) |
For the time being, I've released nextTranslate({ nextTranslate: { basePath: __dirname } }) Note that I've changed the implementation a bit compared to this PR (so you can pass the
|
What is the purpose of this pull request? (put an "X" next to item)
[ ] Documentation update
[ ] Bug fix
[x] New feature
[ ] Other, please explain:
What changes did you make? (Give an overview)
basePath