Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

crypto: move low level crypto into aranya-crypto-core #34

Merged
merged 16 commits into from
Jan 9, 2025
Merged

crypto: move low level crypto into aranya-crypto-core #34

merged 16 commits into from
Jan 9, 2025

Conversation

elagergren-spideroak
Copy link
Member

@elagergren-spideroak elagergren-spideroak commented Jan 7, 2025 •
edited
Loading

This PR attempts to keep aranya-crypto's APIs the same by re-exporting types, etc. Future PRs will start to pare back aranya-crypto.

Fixes #33

@elagergren-spideroak
xyz
ff7b912 
Signed-off-by: Eric Lagergren <[email protected]>
@elagergren-spideroak
x
2563f7b 
Signed-off-by: Eric Lagergren <[email protected]>
@elagergren-spideroak
x
259a816 
Signed-off-by: Eric Lagergren <[email protected]>
@elagergren-spideroak
x
b5fce7a 
Signed-off-by: Eric Lagergren <[email protected]>
@elagergren-spideroak
clean up test vectors, Rng
856a332 
Signed-off-by: Eric Lagergren <[email protected]>
@elagergren-spideroak
cleanup
1337dc5 
Signed-off-by: Eric Lagergren <[email protected]>
@elagergren-spideroak
x
87ce14b 
Signed-off-by: Eric Lagergren <[email protected]>
@elagergren-spideroak
x
6dc9b63 
Signed-off-by: Eric Lagergren <[email protected]>
@elagergren-spideroak
Copy link
Member Author

@ycarmy @jdygert-spok obviously the tests won't pass until we fix CI, but ptal.

@elagergren-spideroak elagergren-spideroak marked this pull request as ready for review January 7, 2025 20:27
@elagergren-spideroak elagergren-spideroak mentioned this pull request Jan 7, 2025
Closed
@elagergren-spideroak
PR fix
ab9b8a7 
Signed-off-by: Eric Lagergren <[email protected]>
ycarmy
ycarmy reviewed Jan 9, 2025
View reviewed changes
Copy link
Contributor

@ycarmy ycarmy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other than my one comment, everything else looks good.

crates/aranya-crypto-core/src/hpke.rs Show resolved Hide resolved
@aranya-project aranya-project deleted a comment from ericlagergren Jan 9, 2025
@elagergren-spideroak elagergren-spideroak enabled auto-merge (squash) January 9, 2025 15:53
@elagergren-spideroak elagergren-spideroak merged commit c73a1c9 into main Jan 9, 2025
12 checks passed
@elagergren-spideroak elagergren-spideroak deleted the issue/33 branch January 9, 2025 16:32
@github-actions github-actions bot mentioned this pull request Jan 11, 2025
Closed
@github-actions github-actions bot mentioned this pull request Jan 15, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ycarmy ycarmy ycarmy approved these changes

@jdygert-spok jdygert-spok jdygert-spok approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

crypto: move low-level crypto into aranya-crypto-core
3 participants
@elagergren-spideroak @ycarmy @jdygert-spok