Weather Api Implementations #1
Conversation
| @@ -0,0 +1,59 @@ | |||
| <!DOCTYPE html> | |||
| <html lang="en"> | |||
There was a problem hiding this comment.
Let's search why do we use lang attribute and does browsers use it?
There was a problem hiding this comment.
Specifies the language code for the element's content. link
index.html
Outdated
| <link rel="stylesheet" href="./dist/css/style.min.css"> | ||
| </head> | ||
| <body> | ||
| <div id="root"></div> |
There was a problem hiding this comment.
Let's remove it if it's not being used anywhere
package-lock.json
Outdated
| @@ -0,0 +1,4515 @@ | |||
| { | |||
There was a problem hiding this comment.
what is this lock file? when does it get updated?
There was a problem hiding this comment.
The goal of the package-lock.json file is to keep track of the exact version of every package that is installed so that a product is 100% reproducible in the same way even if packages are updated by their maintainers.
The dependencies versions will be updated in the package-lock.json file when you run the npm update.
src/js/constants.js
Outdated
| @@ -0,0 +1 @@ | |||
| // Left Empty | |||
There was a problem hiding this comment.
let's remove this file we are not placing any constant in it
src/js/helper/hanlde-error.js
Outdated
| import $ from 'jquery'; | ||
|
|
||
| export default function handleError({response}) { | ||
|
|
There was a problem hiding this comment.
let's remove the extra line break
src/js/helper/hanlde-error.js
Outdated
|
|
||
| $('#notFound').text(message).show(); | ||
| $('#weatherDetails').hide(); | ||
|
|
There was a problem hiding this comment.
let's remove the extra line break
src/js/helper/weather-list.js
Outdated
| @@ -0,0 +1,17 @@ | |||
| export default function getWeatherList (weatherList) { | |||
|
|
|||
There was a problem hiding this comment.
let's remove the extra line breaks
src/js/helper/weather-list.js
Outdated
| @@ -0,0 +1,17 @@ | |||
| export default function getWeatherList (weatherList) { | |||
There was a problem hiding this comment.
We avoid, appending list, dic, map etc with the names and prefer a name that depicts what does it contain, for example weatherDetails
src/js/helper/weather-list.js
Outdated
| @@ -0,0 +1,17 @@ | |||
| export default function getWeatherList (weatherList) { | |||
|
|
|||
| return weatherList.map( weather => { | |||
There was a problem hiding this comment.
let's re consider the name as per the above suggestion,weather
No description provided.