-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Weather Api Implementations #1
Open
arbirali
wants to merge
7
commits into
master
Choose a base branch
from
develop
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 4 commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
e40842a
Weather Api Implementations
arbirali 6e9c118
Update README.md
arbirali 359ef98
Feedback
arbirali 6d00283
Feedback
arbirali 184cdac
Feedback Implementations
arbirali 9bb9c35
Feedback Implementations
arbirali 108b7a8
Delete package-lock.json
arbirali File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -102,3 +102,5 @@ dist | |
|
||
# TernJS port file | ||
.tern-port | ||
|
||
.DS_Store |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1 +1,13 @@ | ||
# weather-api-es | ||
# Weather Api | ||
|
||
## Installation for development | ||
- Clone this repo | ||
- Switch to `develop` branch | ||
- Run the command in terminal `npm i` to install its modules | ||
- Now finally run the command `npm start`. It will automatically open the project in borwser new tab. ``` Or ``` You can go manually to `http://localhost:8080/` | ||
|
||
## Installation for Production | ||
- Clone this repo | ||
- Switch to `develop` branch | ||
- Run the command in terminal `npm i` to install its modules | ||
- Now finally run the command `npm run build` and open the `index.html` file in the browser. |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,59 @@ | ||
<!DOCTYPE html> | ||
<html lang="en"> | ||
<head> | ||
<meta charset="UTF-8"> | ||
<meta name="viewport" content="width=device-width, initial-scale=1.0"> | ||
<title>Document</title> | ||
<link rel="stylesheet" href="https://stackpath.bootstrapcdn.com/bootstrap/4.4.1/css/bootstrap.min.css" integrity="sha384-Vkoo8x4CGsO3+Hhxv8T/Q5PaXtkKtu6ug5TOeNV6gBiFeWPGFN9MuhOf23Q9Ifjh" crossorigin="anonymous"> | ||
<link rel="stylesheet" href="./dist/css/style.min.css"> | ||
</head> | ||
<body> | ||
<div id="root"></div> | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Let's remove it if it's not being used anywhere There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Removed |
||
<div class="wrapper"> | ||
<div class="search-box"> | ||
<form action="#" id="searchForm"> | ||
<div class="input-group"> | ||
<input type="search" id="searchInput" placeholder="Enter City Name" class="form-control" aria-label="Text input with segmented dropdown button"> | ||
<div class="input-group-append"> | ||
<button type="submit" class="btn btn-primary">Search</button> | ||
</div> | ||
</div> | ||
</form> | ||
</div> | ||
<div class="main-content"> | ||
<div class="container"> | ||
<div class="alert alert-danger" role="alert" id="notFound" style="display: none;"></div> | ||
<div id="weatherDetails" style="display: none;"> | ||
<div class="row"> | ||
<div class="col"> | ||
<span id="date"></span> | ||
<div class="address"> | ||
<h1 id="city"></h1> | ||
<span id="country"></span> | ||
</div> | ||
</div> | ||
<div class="col"> | ||
<ul class="info-list"> | ||
<li> | ||
<strong>Sun Rises</strong>: | ||
<span id="sunRize"></span> | ||
</li> | ||
<li> | ||
<strong>Sun Sets</strong>: | ||
<span id="sunSet"></span> | ||
</li> | ||
<li> | ||
<strong>Visibility</strong>: | ||
<span id="visibility"></span>Km | ||
</li> | ||
</ul> | ||
</div> | ||
</div> | ||
<div id="weather" class="row"></div> | ||
</div> | ||
</div> | ||
</div> | ||
</div> | ||
<script src="./dist/js/bundle.js"></script> | ||
</body> | ||
</html> |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's search why do we use lang attribute and does browsers use it?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Specifies the language code for the element's content. link