Non blocking download #34

andreagilardoni · 2024-05-22T10:49:16Z

This PR aims to provide ESP32 OTA with a download that runs in a non blocking fashion, for this reason the code of the download routine is implemented similarly to IOTCloud new implementation released in https://github.com/arduino-libraries/ArduinoIoTCloud/tree/2.0.0

github-actions · 2024-05-22T11:21:39Z

Memory usage change @ d329606

Board	flash	%	RAM for global variables	%
`arduino:esp32:nano_nora`	💚 -227960 - 0	-7.25 - 0.0	💚 -10040 - 0	-3.06 - 0.0
`esp32:esp32:esp32`	💚 -227748 - 0	-17.38 - 0.0	💚 -11200 - 0	-3.42 - 0.0

Click for full report table

Board	`examples/OTA_Arduino_Server` flash	%	`examples/OTA_Arduino_Server` RAM for global variables	%	`examples/OTA_GitHub_Server` flash	%	`examples/OTA_GitHub_Server` RAM for global variables	%	`examples/NANO_ESP32_Blink` flash	%	`examples/NANO_ESP32_Blink` RAM for global variables	%	`examples/LOLIN_32_Blink` flash	%	`examples/LOLIN_32_Blink` RAM for global variables	%
`arduino:esp32:nano_nora`	-225304	-7.16	-10040	-3.06	-227960	-7.25	-10040	-3.06	0	0.0	0	0.0
`esp32:esp32:esp32`	-225076	-17.17	-11200	-3.42	-227748	-17.38	-11200	-3.42					0	0.0	0	0.0

Click for full report CSV

Board,examples/OTA_Arduino_Server<br>flash,%,examples/OTA_Arduino_Server<br>RAM for global variables,%,examples/OTA_GitHub_Server<br>flash,%,examples/OTA_GitHub_Server<br>RAM for global variables,%,examples/NANO_ESP32_Blink<br>flash,%,examples/NANO_ESP32_Blink<br>RAM for global variables,%,examples/LOLIN_32_Blink<br>flash,%,examples/LOLIN_32_Blink<br>RAM for global variables,%
arduino:esp32:nano_nora,-225304,-7.16,-10040,-3.06,-227960,-7.25,-10040,-3.06,0,0.0,0,0.0
esp32:esp32:esp32,-225076,-17.17,-11200,-3.42,-227748,-17.38,-11200,-3.42,,,,,0,0.0,0,0.0

pennam

I would take this chance to move LZSS decoder in a separate library, probably also CRC32 stuff; that code can be reused here and from ArduinoIoTCloud.

Apart from that LGTM

I did not test it 🙂

github-actions · 2024-05-22T12:10:12Z

Memory usage change @ d153911

Board	flash	%	RAM for global variables	%
`arduino:esp32:nano_nora`	💚 -227780 - 0	-7.24 - 0.0	💚 -10040 - 0	-3.06 - 0.0
`esp32:esp32:esp32`	💚 -227568 - 0	-17.36 - 0.0	💚 -11200 - 0	-3.42 - 0.0

Click for full report table

Board	`examples/OTA_Arduino_Server` flash	%	`examples/OTA_Arduino_Server` RAM for global variables	%	`examples/OTA_GitHub_Server` flash	%	`examples/OTA_GitHub_Server` RAM for global variables	%	`examples/NANO_ESP32_Blink` flash	%	`examples/NANO_ESP32_Blink` RAM for global variables	%	`examples/LOLIN_32_Blink` flash	%	`examples/LOLIN_32_Blink` RAM for global variables	%
`arduino:esp32:nano_nora`	-225124	-7.16	-10040	-3.06	-227780	-7.24	-10040	-3.06	0	0.0	0	0.0
`esp32:esp32:esp32`	-224896	-17.16	-11200	-3.42	-227568	-17.36	-11200	-3.42					0	0.0	0	0.0

Click for full report CSV

Board,examples/OTA_Arduino_Server<br>flash,%,examples/OTA_Arduino_Server<br>RAM for global variables,%,examples/OTA_GitHub_Server<br>flash,%,examples/OTA_GitHub_Server<br>RAM for global variables,%,examples/NANO_ESP32_Blink<br>flash,%,examples/NANO_ESP32_Blink<br>RAM for global variables,%,examples/LOLIN_32_Blink<br>flash,%,examples/LOLIN_32_Blink<br>RAM for global variables,%
arduino:esp32:nano_nora,-225124,-7.16,-10040,-3.06,-227780,-7.24,-10040,-3.06,0,0.0,0,0.0
esp32:esp32:esp32,-224896,-17.16,-11200,-3.42,-227568,-17.36,-11200,-3.42,,,,,0,0.0,0,0.0

pennam · 2024-05-22T12:15:31Z

This PR should also fix #28

github-actions · 2024-05-23T13:18:08Z

Memory usage change @ 38bdbc3

Board	flash	%	RAM for global variables	%
`arduino:esp32:nano_nora`	💚 -227760 - 0	-7.24 - 0.0	💚 -10040 - 0	-3.06 - 0.0
`esp32:esp32:esp32`	💚 -227548 - 0	-17.36 - 0.0	💚 -11200 - 0	-3.42 - 0.0

Click for full report table

Board	`examples/OTA_Arduino_Server` flash	%	`examples/OTA_Arduino_Server` RAM for global variables	%	`examples/OTA_GitHub_Server` flash	%	`examples/OTA_GitHub_Server` RAM for global variables	%	`examples/NANO_ESP32_Blink` flash	%	`examples/NANO_ESP32_Blink` RAM for global variables	%	`examples/LOLIN_32_Blink` flash	%	`examples/LOLIN_32_Blink` RAM for global variables	%
`arduino:esp32:nano_nora`	-225104	-7.16	-10040	-3.06	-227760	-7.24	-10040	-3.06	0	0.0	0	0.0
`esp32:esp32:esp32`	-224876	-17.16	-11200	-3.42	-227548	-17.36	-11200	-3.42					0	0.0	0	0.0

Click for full report CSV

Board,examples/OTA_Arduino_Server<br>flash,%,examples/OTA_Arduino_Server<br>RAM for global variables,%,examples/OTA_GitHub_Server<br>flash,%,examples/OTA_GitHub_Server<br>RAM for global variables,%,examples/NANO_ESP32_Blink<br>flash,%,examples/NANO_ESP32_Blink<br>RAM for global variables,%,examples/LOLIN_32_Blink<br>flash,%,examples/LOLIN_32_Blink<br>RAM for global variables,%
arduino:esp32:nano_nora,-225104,-7.16,-10040,-3.06,-227760,-7.24,-10040,-3.06,0,0.0,0,0.0
esp32:esp32:esp32,-224876,-17.16,-11200,-3.42,-227548,-17.36,-11200,-3.42,,,,,0,0.0,0,0.0

github-actions · 2024-05-23T14:56:18Z

Memory usage change @ 046e03f

Board	flash	%	RAM for global variables	%
`arduino:esp32:nano_nora`	💚 -227868 - 0	-7.24 - 0.0	💚 -10040 - 0	-3.06 - 0.0
`esp32:esp32:esp32`	💚 -227656 - 0	-17.37 - 0.0	💚 -11200 - 0	-3.42 - 0.0

Click for full report table

Board	`examples/OTA_Arduino_Server` flash	%	`examples/OTA_Arduino_Server` RAM for global variables	%	`examples/OTA_GitHub_Server` flash	%	`examples/OTA_GitHub_Server` RAM for global variables	%	`examples/NANO_ESP32_Blink` flash	%	`examples/NANO_ESP32_Blink` RAM for global variables	%	`examples/LOLIN_32_Blink` flash	%	`examples/LOLIN_32_Blink` RAM for global variables	%
`arduino:esp32:nano_nora`	-225212	-7.16	-10040	-3.06	-227868	-7.24	-10040	-3.06	0	0.0	0	0.0
`esp32:esp32:esp32`	-224984	-17.16	-11200	-3.42	-227656	-17.37	-11200	-3.42					0	0.0	0	0.0

Click for full report CSV

Board,examples/OTA_Arduino_Server<br>flash,%,examples/OTA_Arduino_Server<br>RAM for global variables,%,examples/OTA_GitHub_Server<br>flash,%,examples/OTA_GitHub_Server<br>RAM for global variables,%,examples/NANO_ESP32_Blink<br>flash,%,examples/NANO_ESP32_Blink<br>RAM for global variables,%,examples/LOLIN_32_Blink<br>flash,%,examples/LOLIN_32_Blink<br>RAM for global variables,%
arduino:esp32:nano_nora,-225212,-7.16,-10040,-3.06,-227868,-7.24,-10040,-3.06,0,0.0,0,0.0
esp32:esp32:esp32,-224984,-17.16,-11200,-3.42,-227656,-17.37,-11200,-3.42,,,,,0,0.0,0,0.0

github-actions · 2024-05-24T11:48:05Z

Memory usage change @ 32ff784

Board	flash	%	RAM for global variables	%
`arduino:esp32:nano_nora`	💚 -227864 - 0	-7.24 - 0.0	💚 -10040 - 0	-3.06 - 0.0
`esp32:esp32:esp32`	💚 -227652 - 0	-17.37 - 0.0	💚 -11200 - 0	-3.42 - 0.0

Click for full report table

Board	`examples/OTA_Arduino_Server` flash	%	`examples/OTA_Arduino_Server` RAM for global variables	%	`examples/OTA_GitHub_Server` flash	%	`examples/OTA_GitHub_Server` RAM for global variables	%	`examples/NANO_ESP32_Blink` flash	%	`examples/NANO_ESP32_Blink` RAM for global variables	%	`examples/LOLIN_32_Blink` flash	%	`examples/LOLIN_32_Blink` RAM for global variables	%
`arduino:esp32:nano_nora`	-225208	-7.16	-10040	-3.06	-227864	-7.24	-10040	-3.06	0	0.0	0	0.0
`esp32:esp32:esp32`	-224980	-17.16	-11200	-3.42	-227652	-17.37	-11200	-3.42					0	0.0	0	0.0

Click for full report CSV

Board,examples/OTA_Arduino_Server<br>flash,%,examples/OTA_Arduino_Server<br>RAM for global variables,%,examples/OTA_GitHub_Server<br>flash,%,examples/OTA_GitHub_Server<br>RAM for global variables,%,examples/NANO_ESP32_Blink<br>flash,%,examples/NANO_ESP32_Blink<br>RAM for global variables,%,examples/LOLIN_32_Blink<br>flash,%,examples/LOLIN_32_Blink<br>RAM for global variables,%
arduino:esp32:nano_nora,-225208,-7.16,-10040,-3.06,-227864,-7.24,-10040,-3.06,0,0.0,0,0.0
esp32:esp32:esp32,-224980,-17.16,-11200,-3.42,-227652,-17.37,-11200,-3.42,,,,,0,0.0,0,0.0

github-actions · 2024-05-27T08:11:02Z

Memory usage change @ 93c64ee

Board	flash	%	RAM for global variables	%
`arduino:esp32:nano_nora`	💚 -227864 - 0	-7.24 - 0.0	💚 -10040 - 0	-3.06 - 0.0
`esp32:esp32:esp32`	💚 -227652 - 0	-17.37 - 0.0	💚 -11200 - 0	-3.42 - 0.0

Click for full report table

Board	`examples/OTA_Arduino_Server` flash	%	`examples/OTA_Arduino_Server` RAM for global variables	%	`examples/OTA_GitHub_Server` flash	%	`examples/OTA_GitHub_Server` RAM for global variables	%	`examples/NANO_ESP32_Blink` flash	%	`examples/NANO_ESP32_Blink` RAM for global variables	%	`examples/LOLIN_32_Blink` flash	%	`examples/LOLIN_32_Blink` RAM for global variables	%
`arduino:esp32:nano_nora`	-225208	-7.16	-10040	-3.06	-227864	-7.24	-10040	-3.06	0	0.0	0	0.0
`esp32:esp32:esp32`	-224980	-17.16	-11200	-3.42	-227652	-17.37	-11200	-3.42					0	0.0	0	0.0

Click for full report CSV

Board,examples/OTA_Arduino_Server<br>flash,%,examples/OTA_Arduino_Server<br>RAM for global variables,%,examples/OTA_GitHub_Server<br>flash,%,examples/OTA_GitHub_Server<br>RAM for global variables,%,examples/NANO_ESP32_Blink<br>flash,%,examples/NANO_ESP32_Blink<br>RAM for global variables,%,examples/LOLIN_32_Blink<br>flash,%,examples/LOLIN_32_Blink<br>RAM for global variables,%
arduino:esp32:nano_nora,-225208,-7.16,-10040,-3.06,-227864,-7.24,-10040,-3.06,0,0.0,0,0.0
esp32:esp32:esp32,-224980,-17.16,-11200,-3.42,-227652,-17.37,-11200,-3.42,,,,,0,0.0,0,0.0

github-actions · 2024-05-27T08:21:09Z

Memory usage change @ 47a716f

Board	flash	%	RAM for global variables	%
`arduino:esp32:nano_nora`	💚 -227864 - 0	-7.24 - 0.0	💚 -10040 - 0	-3.06 - 0.0
`esp32:esp32:esp32`	💚 -227652 - 0	-17.37 - 0.0	💚 -11200 - 0	-3.42 - 0.0

Click for full report table

Board	`examples/OTA_Arduino_Server` flash	%	`examples/OTA_Arduino_Server` RAM for global variables	%	`examples/OTA_GitHub_Server` flash	%	`examples/OTA_GitHub_Server` RAM for global variables	%	`examples/NANO_ESP32_Blink` flash	%	`examples/NANO_ESP32_Blink` RAM for global variables	%	`examples/LOLIN_32_Blink` flash	%	`examples/LOLIN_32_Blink` RAM for global variables	%
`arduino:esp32:nano_nora`	-225208	-7.16	-10040	-3.06	-227864	-7.24	-10040	-3.06	0	0.0	0	0.0
`esp32:esp32:esp32`	-224980	-17.16	-11200	-3.42	-227652	-17.37	-11200	-3.42					0	0.0	0	0.0

Click for full report CSV

Board,examples/OTA_Arduino_Server<br>flash,%,examples/OTA_Arduino_Server<br>RAM for global variables,%,examples/OTA_GitHub_Server<br>flash,%,examples/OTA_GitHub_Server<br>RAM for global variables,%,examples/NANO_ESP32_Blink<br>flash,%,examples/NANO_ESP32_Blink<br>RAM for global variables,%,examples/LOLIN_32_Blink<br>flash,%,examples/LOLIN_32_Blink<br>RAM for global variables,%
arduino:esp32:nano_nora,-225208,-7.16,-10040,-3.06,-227864,-7.24,-10040,-3.06,0,0.0,0,0.0
esp32:esp32:esp32,-224980,-17.16,-11200,-3.42,-227652,-17.37,-11200,-3.42,,,,,0,0.0,0,0.0

Added the possibility to run download in a non blocking fashion

andreagilardoni force-pushed the non-blocking-download branch from 23c6493 to 2dbf0fb Compare May 22, 2024 11:16

andreagilardoni requested a review from pennam May 22, 2024 11:21

andreagilardoni marked this pull request as draft May 22, 2024 11:50

pennam approved these changes May 22, 2024

View reviewed changes

andreagilardoni force-pushed the non-blocking-download branch from d329606 to d153911 Compare May 22, 2024 12:00

andreagilardoni marked this pull request as ready for review May 22, 2024 12:10

per1234 linked an issue May 22, 2024 that may be closed by this pull request

Download url parser discards port #28

Closed

andreagilardoni marked this pull request as draft May 23, 2024 13:07

per1234 added type: enhancement Proposed improvement topic: code Related to content of the project itself labels May 23, 2024

andreagilardoni force-pushed the non-blocking-download branch from 046e03f to 32ff784 Compare May 24, 2024 11:41

andreagilardoni marked this pull request as ready for review May 24, 2024 11:48

andreagilardoni force-pushed the non-blocking-download branch from 32ff784 to 93c64ee Compare May 27, 2024 08:06

andreagilardoni force-pushed the non-blocking-download branch from 93c64ee to 47a716f Compare May 27, 2024 08:13

andreagilardoni added 8 commits May 27, 2024 10:21

Added ArduinoHttpClient as depencency

8df53a8

removing uri implementation in favor of HttpClient

594ea2f

updating LZSS implementation to be in line with IotCloud

672403c

updating root ca for downloads.arduino.cc

7ef7da5

fixing typo

95673bc

added missing headers

03ce37c

Improving ESP32 ota to be inline with new IoTCloud implementation

2d503d0

Added the possibility to run download in a non blocking fashion

added ArduinoHttpClient as CI dependency

080e75e

splitting update into verify function

13c6009

andreagilardoni force-pushed the non-blocking-download branch from 47a716f to 13c6009 Compare May 27, 2024 08:21

andreagilardoni merged commit 72e71bf into main May 27, 2024
9 checks passed

pennam deleted the non-blocking-download branch November 26, 2024 08:04

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Non blocking download #34

Non blocking download #34

andreagilardoni commented May 22, 2024

github-actions bot commented May 22, 2024

pennam left a comment

github-actions bot commented May 22, 2024

pennam commented May 22, 2024

github-actions bot commented May 23, 2024

github-actions bot commented May 23, 2024

github-actions bot commented May 24, 2024

github-actions bot commented May 27, 2024

github-actions bot commented May 27, 2024

Non blocking download #34

Non blocking download #34

Conversation

andreagilardoni commented May 22, 2024

github-actions bot commented May 22, 2024

pennam left a comment

Choose a reason for hiding this comment

github-actions bot commented May 22, 2024

pennam commented May 22, 2024

github-actions bot commented May 23, 2024

github-actions bot commented May 23, 2024

github-actions bot commented May 24, 2024

github-actions bot commented May 27, 2024

github-actions bot commented May 27, 2024