fillScreen: trigger a redraw of the screen #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
From the Forum thread: https://forum.arduino.cc/t/problem-with-fillscreen/1218319 The following sketch does not show anything on the screen: ``` #include "Arduino.h" //#include "SPI.h" #include "Arduino_GigaDisplay_GFX.h" GigaDisplay_GFX tft; #define GC9A01A_CYAN 0x07FF #define GC9A01A_RED 0xf800 #define GC9A01A_BLUE 0x001F #define GC9A01A_GREEN 0x07E0 #define GC9A01A_MAGENTA 0xF81F #define GC9A01A_WHITE 0xffff #define GC9A01A_BLACK 0x0000 #define GC9A01A_YELLOW 0xFFE0 #define WHITE 0xffff #define BLACK 0x0000 void setup() { Serial.begin(115200); tft.begin(); tft.fillScreen(GC9A01A_GREEN); yield(); delay(3000); tft.fillScreen(GC9A01A_BLUE); yield(); delay(3000); tft.fillScreen(GC9A01A_YELLOW); Serial.println("Done"); } void loop() { // put your main code here, to run repeatedly: } ``` Problem was you implemented your own version of fillScreen, which did not have the startWrite() and more specific endWrite() calls in it, and as such your dirty flag was not set.
|
The same fix also needs to be applied to drawFastRawH/Vline. |
gilesp1729
added a commit
to gilesp1729/Arduino_GigaDisplay_GFX
that referenced
this pull request
May 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
From the Forum thread:
https://forum.arduino.cc/t/problem-with-fillscreen/1218319
The following sketch does not show anything on the screen:
Problem was you implemented your own version of fillScreen, which did not have the startWrite() and more specific endWrite() calls in it, and as such your dirty flag was not set.