Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(deps): bump github.com/Azure/azure-sdk-for-go/sdk/storage/azblob from 1.2.1 to 1.3.0 #12667

Conversation

roelarents
Copy link
Contributor

@roelarents roelarents commented Feb 15, 2024

Bumps github.com/Azure/azure-sdk-for-go/sdk/storage/azblob from 1.2.1 to 1.3.0.

Fix for a data race issue in azure azblob sdk.

Motivation

Update azure-sdk-for-go/sdk/storage/azblob to the latest version.

Dependabot would normally do this, but it has been explicitly disabled once and cannot be enabled again.

Modifications

A version update in go.mod. Ran go mod tidy.

Verification

Tested by:

  • make test

@roelarents roelarents marked this pull request as ready for review February 15, 2024 10:37
@agilgur5 agilgur5 added type/dependencies PRs and issues specific to updating dependencies go Pull requests that update Go dependencies area/artifacts S3/GCP/OSS/Git/HDFS etc area/upstream This is an issue with an upstream dependency, not Argo itself labels Feb 15, 2024
@agilgur5
Copy link

Replaces #12532

Copy link

@agilgur5 agilgur5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested by:

Were you able to test that this fixed the issue you were having?

@agilgur5 agilgur5 changed the title chore: bump github.com/Azure/azure-sdk-for-go/sdk/storage/azblob chore: bump github.com/Azure/azure-sdk-for-go/sdk/storage/azblob to 1.3.0 Feb 15, 2024
@agilgur5 agilgur5 changed the title chore: bump github.com/Azure/azure-sdk-for-go/sdk/storage/azblob to 1.3.0 chore: bump github.com/Azure/azure-sdk-for-go/sdk/storage/azblob from 1.2.1 to 1.3.0 Feb 15, 2024
@roelarents
Copy link
Contributor Author

not yet. i intend to patch 3.5.4 tomorrow or next week and run it in production. since it is not easily reproducible

@agilgur5 agilgur5 self-assigned this Feb 16, 2024
@roelarents
Copy link
Contributor Author

A requirement for https for azure blob connections with shared key credentials was added In 1.3.0, which breaks our test setup.
It will be reverted in the next release. I will wait for that.

@agilgur5 agilgur5 added the problem/more information needed Not enough information has been provide to diagnose this issue. label Mar 9, 2024
Copy link
Contributor

This PR has been automatically marked as stale because it has not had recent activity and needs further changes. It will be closed if no further activity occurs.

@github-actions github-actions bot added the problem/stale This has not had a response in some time label Mar 24, 2024
Copy link
Contributor

github-actions bot commented Apr 8, 2024

This PR has been closed due to inactivity and lack of changes. If you would like to still work on this PR, please address the review comments and re-open.

@agilgur5
Copy link

agilgur5 commented Apr 9, 2024

Superseded by #12915

@agilgur5 agilgur5 added solution/superseded This PR or issue has been superseded by another one (slightly different from a duplicate) go Pull requests that update Go dependencies and removed go Pull requests that update Go dependencies problem/stale This has not had a response in some time problem/more information needed Not enough information has been provide to diagnose this issue. labels Apr 9, 2024
@agilgur5 agilgur5 changed the title chore: bump github.com/Azure/azure-sdk-for-go/sdk/storage/azblob from 1.2.1 to 1.3.0 fix(deps): bump github.com/Azure/azure-sdk-for-go/sdk/storage/azblob from 1.2.1 to 1.3.0 Apr 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/artifacts S3/GCP/OSS/Git/HDFS etc area/upstream This is an issue with an upstream dependency, not Argo itself go Pull requests that update Go dependencies solution/superseded This PR or issue has been superseded by another one (slightly different from a duplicate) type/dependencies PRs and issues specific to updating dependencies
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants