chore(lint): enable testifylint #13467
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit enables testifylint and fixes the 5 changes that have crept in since the beginning of trying to enable it. Signed-off-by: Alan Clucas <[email protected]>
terrytangyuan
approved these changes
Aug 14, 2024
MasonM
added a commit
to MasonM/argo-workflows
that referenced
this pull request
Nov 2, 2024
Every PR has been failing the `make lint` checked with the following error since argoproj#12960 was merged: ``` assert.Equal(t, 1, len(status.Outputs.Parameters)) ^ Error: test/e2e/suspend_test.go:124:4: len: use assert.Len (testifylint) assert.Equal(t, 1, len(status.Inputs.Parameters)) ^ make: *** [Makefile:466: lint] Error 1 ``` This is happening due to a conflict between that PR and argoproj#13467. The latter PR was merged on August 14th, but the latest CI run for the former (https://github.com/argoproj/argo-workflows/actions/runs/9191558853/job/25278229097) was on May 22nd. Signed-off-by: Mason Malone <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit enables testifylint and fixes the 5 changes that have crept in since the beginning of trying to enable it.
This is part of a series which aimed to get this enabled as a useful linter.
The version of golangci-lint we use is a bit old (1.55.1), and isn't catching all the things I was expecting. Once this is merged I'll do a follow up to bump golangci-lint to latest (1.60.1) as well.
Signed-off-by: Alan Clucas [email protected]