Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add workflow #249

Draft
wants to merge 8 commits into
base: develop
Choose a base branch
from
Draft

Conversation

chetryan
Copy link
Contributor

@chetryan chetryan commented Mar 27, 2023

Overview

I would like to propose adding linting and unittesting as a github action that would run on each branch.

Adds

  • a new workflow to run on each push, that will run linting and unit tests

Pending

  • checks, so that merges to develop cannot be done unless unit tests pass

@chetryan chetryan marked this pull request as ready for review March 27, 2023 16:44
@chetryan chetryan marked this pull request as draft March 27, 2023 16:45
Copy link
Contributor

@mharista mharista left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Comment out pylint for now until repo is fully converted to python3 only.

- name: Lint with pylinit
continue-on-error: true
run: |
make pylint
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cvprac needs a lot of updates to support pylint on python3 so I'm thinking for now we comment this out?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants