-
Notifications
You must be signed in to change notification settings - Fork 48
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add workflow #249
Draft
chetryan
wants to merge
8
commits into
aristanetworks:develop
Choose a base branch
from
chetryan:add_workflow
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Add workflow #249
Changes from all commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
5406d8f
Feat(workflow): Add initial workflow for unittest
chetryan cd1e5a4
Fix(workflow): Missing trigger
chetryan 3171cf8
Feat(workflow): Attempt use of matrix
chetryan 38f3cdd
Fix(workflow): installation of dev-requirements
chetryan 10c15f8
Fix(workflow): Continue if linting fails
chetryan c95c755
WIP(workflow): skip linting
chetryan 266aeab
Feat(workflow): try to continue if linting fails
chetryan 2755d81
Feat(workflow): Add coverage
chetryan File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,32 @@ | ||
--- | ||
name: Run Unit-tests | ||
|
||
on: push | ||
|
||
jobs: | ||
run_unit_test: | ||
runs-on: ubuntu-22.04 | ||
strategy: | ||
matrix: | ||
python-version: ["3.8", "3.9", "3.10"] | ||
|
||
steps: | ||
- uses: actions/checkout@v3 | ||
- name: Set up Python ${{ matrix.python-version }} | ||
uses: actions/setup-python@v4 | ||
with: | ||
python-version: ${{ matrix.python-version }} | ||
- name: Install dependencies | ||
run: | | ||
python -m pip install --upgrade pip | ||
if [ -f requirements.txt ]; then pip install -r requirements.txt; fi | ||
if [ -f dev-requirements.txt ]; then pip install -r dev-requirements.txt; fi | ||
- name: Lint with pylinit | ||
continue-on-error: true | ||
run: | | ||
make pylint | ||
- name: Run unit tests | ||
if: success() || failure() | ||
run: | | ||
make unittest | ||
make coverage_report |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
cvprac needs a lot of updates to support pylint on python3 so I'm thinking for now we comment this out?