Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for multi source download when using https protocol #3306

Merged
merged 3 commits into from
Jan 12, 2022

Conversation

igorpecovnik
Copy link
Member

@igorpecovnik igorpecovnik commented Dec 2, 2021

Description

When deploying build framework for the first time it downloads toolchains which is stored on our network. We provide https and torrent download options. Both variants support downloading from multiple sources simultaneously but for some reason, https download did properly add additional seeds due to the wrong quote placement.

@lanefu Is it possible to show "all mirrors for your zone" via curl -s https://redirect.armbian.com/

Jira reference number AR-1015

How Has This Been Tested?

Manual installations on a clean host.

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • Any dependent changes have been merged and published in downstream modules

@igorpecovnik igorpecovnik marked this pull request as draft December 2, 2021 12:57
@igorpecovnik igorpecovnik marked this pull request as ready for review December 2, 2021 12:57
@lanefu
Copy link
Member

lanefu commented Dec 2, 2021

@lanefu Is it possible to show "all mirrors for your zone" via curl -s https://redirect.armbian.com/

@igorpecovnik no but that's a good idea. Created armbian/dl-router#24

@lanefu
Copy link
Member

lanefu commented Jan 12, 2022

Oh yes is a solution

lane@blipsqueak ~> CODE=$(curl -s redirect.armbian.com/geoip | jq '.continent.code' -r)                                                                         lane@blipsqueak ~> curl -s redirect.armbian.com/mirrors | jq .${CODE}           [                                                                                 "https://mirror.12z.eu/pub/linux/armbian/dl/",
  "https://armbian.tnahosting.net/dl/",
  "https://armbian.lv.auroradev.org/dl/"
]

- set https download as default since its downloading from multiple closest servers by default
@igorpecovnik igorpecovnik changed the title Bugfix - toolchain download only from a single source Add support for downloading from multiple sources when using https protocol Jan 12, 2022
@igorpecovnik igorpecovnik changed the title Add support for downloading from multiple sources when using https protocol Support for multi source download when using https protocol Jan 12, 2022
@igorpecovnik igorpecovnik merged commit 0344d20 into master Jan 12, 2022
@igorpecovnik igorpecovnik deleted the AR-1015 branch January 12, 2022 06:49
useful64 pushed a commit to useful64/build that referenced this pull request Feb 4, 2022
…3306)

* Bugfix - toolchain download only from a single source

* - replaced hardcoded continent value with dynamic
- set https download as default since its downloading from multiple closest servers by default
useful64 pushed a commit to useful64/build that referenced this pull request Feb 4, 2022
…3306)

* Bugfix - toolchain download only from a single source

* - replaced hardcoded continent value with dynamic
- set https download as default since its downloading from multiple closest servers by default
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants