Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Added a few small fixes for the nfsd module while reviewing it for my Samba work.
Implementation Details
Added a small wrapper script to abstract away dealing with systemd services. I work inside a container (using systemd-nspawn) so all commands attempting to start/stop/restart a service fail.
Fixed
status
command which didn't work inside the container due to failingsystemctl is-active
command. Plus, checking if the service is active is not the same as checking if it was installed.Fixed
uninstall
command, which should beremove
instead.See above.
Confirmed.
Documentation Summary
None.
None.
Testing Procedure
Installed and uninstalled nfsd inside the container a few times.
Checklist