Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nfsd fixes #312

Closed
wants to merge 3 commits into from
Closed

nfsd fixes #312

wants to merge 3 commits into from

Conversation

dimitry-ishenko
Copy link
Collaborator

Description

Added a few small fixes for the nfsd module while reviewing it for my Samba work.

Implementation Details

  • Key changes introduced by this PR
  1. Added a small wrapper script to abstract away dealing with systemd services. I work inside a container (using systemd-nspawn) so all commands attempting to start/stop/restart a service fail.

  2. Fixed status command which didn't work inside the container due to failing systemctl is-active command. Plus, checking if the service is active is not the same as checking if it was installed.

  3. Fixed uninstall command, which should be remove instead.

  • Justification for the changes

See above.

  • Confirmation that no new external dependencies or modules have been introduced

Confirmed.

Documentation Summary

  • Metadata Included:

None.

  • Document Generated:

None.

Testing Procedure

Installed and uninstalled nfsd inside the container a few times.

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have ensured that my changes do not introduce new warnings or errors
  • No new external dependencies are included
  • Changes have been tested and verified
  • I have included necessary metadata in the code, including associative arrays

@github-actions github-actions bot added the size/small PR with less then 50 lines label Dec 11, 2024
@igorpecovnik
Copy link
Member

Thank you! This will be useful elsewhere too.

I already went further here, so I cherry-picked your commits into my branch.

@dimitry-ishenko dimitry-ishenko deleted the nfsd-fixes branch December 11, 2024 15:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size/small PR with less then 50 lines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants