feat: introduce readiness and liveness probe feature #73
Conversation
RealAnna
force-pushed
the
feat/add_probes
branch
from
4f33263
to
5998d13
Compare
RealAnna
force-pushed
the
feat/add_probes
branch
2 times, most recently
from
22e03cd
to
c4a0299
Compare
RealAnna
force-pushed
the
feat/add_probes
branch
from
c4a0299
to
b16d3ea
Compare
RealAnna
force-pushed
the
feat/add_probes
branch
from
f3e7c36
to
b00f847
Compare
|
@arttor does this version make sense now ? 😸 |
|
@RealAnna looks good. Can you please regenerate samples without using flags? Repo samples should represent default behavior. |
|
@arttor can this be merged now or should I fix something else? |
| @@ -98,6 +85,26 @@ spec: | |||
| subPath: controller_manager_config.yaml | |||
| - mountPath: /my.ca | |||
| name: secret-volume | |||
| {{- if .Values.controllerManager.manager.livenessProbe }} | |||
There was a problem hiding this comment.
should Values.controllerManager.manager.livenessProbe be in values.yaml if probe is presented in source manifest?
There was a problem hiding this comment.
yeah for consistency
There was a problem hiding this comment.
please check that it is in values.yaml if flag is enabled. values.yaml was not updated, only template
| initialDelaySeconds: 15 | ||
| periodSeconds: 20 | ||
| {{- end }} | ||
| {{- if .Values.controllerManager.manager.readinessProbe }} |
There was a problem hiding this comment.
should we template probes only if probes=true and leave it as it is by default?
There was a problem hiding this comment.
@attor I am a bit confused, so if probes= true we template and add values otherwise I would expect to have just the probe in the deployment, correct?
There was a problem hiding this comment.
we template probes only if probes=true and probes are presented in the source manifest. if any of these conditions is false then we do nothing.
Signed-off-by: RealAnna <[email protected]> feat: introduced liveness and readiness probes Signed-off-by: RealAnna <[email protected]> feat: introduced liveness and readiness probes Signed-off-by: RealAnna <[email protected]>
Signed-off-by: RealAnna <[email protected]>
RealAnna
force-pushed
the
feat/add_probes
branch
from
7d6451d
to
8ba0e50
Compare
this PR adds configurable liveness and readiness probes
with cli -probes=true readynessprobes and livenessprobes are templated with a completely customizable probe or the copy of the probes in the input
by default the feature is disabled